Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5641)

Unified Diff: chrome/browser/plugins/plugins_field_trial.cc

Issue 2391823003: [HBD] Hardcode SEI threshold to 30 (for testers) (Closed)
Patch Set: fix one more test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugins_field_trial.cc
diff --git a/chrome/browser/plugins/plugins_field_trial.cc b/chrome/browser/plugins/plugins_field_trial.cc
index 6e586aa0371f35c1c74ff17779769f57e83935eb..a84a9cd809d4037da7855449338f9a24b192bcc4 100644
--- a/chrome/browser/plugins/plugins_field_trial.cc
+++ b/chrome/browser/plugins/plugins_field_trial.cc
@@ -12,8 +12,9 @@
namespace {
// The default site engagement threshold to allow Flash to be presented as an
-// available plugin.
-const double kSiteEngagementThresholdForFlash = 1.0;
+// available plugin. This value is not used for normal uses, but only for
+// developers / testers that don't have a field trial configuration.
+const double kDefaultSiteEngagementThresholdForFlash = 30.0;
} // namespace
@@ -45,5 +46,5 @@ double PluginsFieldTrial::GetSiteEngagementThresholdForFlash() {
PluginsFieldTrial::kSiteEngagementThresholdForFlashKey);
if (base::StringToDouble(param, &threshold) && threshold >= 0)
return threshold;
- return kSiteEngagementThresholdForFlash;
+ return kDefaultSiteEngagementThresholdForFlash;
}

Powered by Google App Engine
This is Rietveld 408576698