Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

Issue 2391753002: [Android] Fix search engine page crash when users change language (Closed)
Patch Set: update based on Theresa's comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
index a48eea848cdd77a554d82408ec4a1e7adeeac058..2982f4655b569ebc5f0c5669be2d5b9146ebb267 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
@@ -103,7 +103,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On
if (!templateUrlService.isLoaded()) {
templateUrlService.registerLoadListener(this);
templateUrlService.load();
- return; // Flow continues in onTemplateUrlServiceLoaded below.
+ return;
}
Theresa 2016/10/03 23:50:09 nit: add this comment back?
// Fetch all the search engine info and the currently active one.
@@ -129,7 +129,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On
@Override
public int getCount() {
- return mSearchEngines.size();
+ return mSearchEngines == null ? 0 : mSearchEngines.size();
}
@Override
@@ -222,6 +222,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On
public void onTemplateUrlServiceLoaded() {
TemplateUrlService.getInstance().unregisterLoadListener(this);
initEntries();
+ notifyDataSetChanged();
}
// OnClickListener:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698