[Android] Fix search engine page crash when users change language

chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences;
 
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.res.Resources;
@@ skipping 85 matching lines @@
     }
 
     /**
      * Initialize the search engine list.
      */
     private void initEntries() {
         TemplateUrlService templateUrlService = TemplateUrlService.getInstance();
         if (!templateUrlService.isLoaded()) {
             templateUrlService.registerLoadListener(this);
             templateUrlService.load();
-            return;  // Flow continues in onTemplateUrlServiceLoaded below.
+            return;
         }

[Theresa, 2016/10/03 23:50:09]

nit: add this comment back?

 
         // Fetch all the search engine info and the currently active one.
         mSearchEngines = templateUrlService.getLocalizedSearchEngines();
         int searchEngineIndex = templateUrlService.getDefaultSearchEngineIndex();
         // Convert the TemplateUrl index into an index into mSearchEngines.
         mSelectedSearchEnginePosition = -1;
         for (int i = 0; i < mSearchEngines.size(); ++i) {
             if (mSearchEngines.get(i).getIndex() == searchEngineIndex) {
                 mSelectedSearchEnginePosition = i;
             }
         }
 
         // Report back what is selected.
         mCallback.currentSearchEngineDetermined(toIndex(mSelectedSearchEnginePosition));
     }
 
     private int toIndex(int position) {
         return mSearchEngines.get(position).getIndex();
     }
 
     // BaseAdapter:
 
     @Override
     public int getCount() {
-        return mSearchEngines.size();
+        return mSearchEngines == null ? 0 : mSearchEngines.size();
     }
 
     @Override
     public Object getItem(int pos) {
         TemplateUrl templateUrl = mSearchEngines.get(pos);
         return templateUrl.getShortName();
     }
 
     @Override
     public long getItemId(int position) {
@@ skipping 72 matching lines @@
 
         return view;
     }
 
     // TemplateUrlService.LoadListener
 
     @Override
     public void onTemplateUrlServiceLoaded() {
         TemplateUrlService.getInstance().unregisterLoadListener(this);
         initEntries();
+        notifyDataSetChanged();
     }
 
     // OnClickListener:
 
     @Override
     public void onClick(View view) {
         if (view.getTag() == null) {
             onLocationLinkClicked();
         } else {
             searchEngineSelected((int) view.getTag());
@@ skipping 47 matching lines @@
                 toIndex(position));
         GeolocationInfo locationSettings = new GeolocationInfo(url, null, false);
         ContentSetting locationPermission = locationSettings.getContentSetting();
         // Handle the case where the geoHeader being sent when no permission has been specified.
         if (locationPermission == ContentSetting.ASK && checkGeoHeader) {
             return GeolocationHeader.isGeoHeaderEnabledForUrl(mContext, url, false);
         }
         return locationPermission == ContentSetting.ALLOW;
     }
 }