[Android] Fix search engine page crash when users change language

[Android] Fix search engine page crash when users change language

When changeing language setting of phones, Template Url Service
will be changed and unloaded. Then when search engine setting page back
to active from background, it fires a NoPointerException for popluating
the Listview when Template Url Service is still loading.

To fix that, check whether Template Url Service is already loaded before
populating UI, if not, force it to load and meanwhile, close the
fragment to prevent from crash.

BUG=652170
Committed: https://crrev.com/e8efd3e036c037831a92d41604004b61b0d9f307
Cr-Commit-Position: refs/heads/master@{#422660}

[ltian, 2016-10-03 20:57:40]

ltian@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2016-10-03 23:03:12]

https://codereview.chromium.org/2391753002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2391753002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:131:
return mSearchEngines.size();
Instead of finishing the activity, could you do something like this for
getCount()?

return mSearchEngines == null ? 0 : mSearchEngines.size();



Then once the template url service is loaded, the adapters count will change and
the view should populate with the options. You may have to call
notifyDataSetChanged() once the entries list has been populated.

https://developer.android.com/reference/android/widget/BaseAdapter.html#notif...

[ltian, 2016-10-03 23:48:25]

https://codereview.chromium.org/2391753002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(right):

https://codereview.chromium.org/2391753002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:131:
return mSearchEngines.size();
On 2016/10/03 23:03:12, Theresa Wellington wrote:
> Instead of finishing the activity, could you do something like this for
> getCount()?
> 
> return mSearchEngines == null ? 0 : mSearchEngines.size();
> 
> 
> 
> Then once the template url service is loaded, the adapters count will change
and
> the view should populate with the options. You may have to call
> notifyDataSetChanged() once the entries list has been populated.
> 
>
https://developer.android.com/reference/android/widget/BaseAdapter.html#notif...

That's a better solution! Done.

[Theresa, 2016-10-03 23:50:09]

One nit and the CL description needs to be updated.

Otherwise, lgtm!

https://codereview.chromium.org/2391753002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
(left):

https://codereview.chromium.org/2391753002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java:107:
}
nit: add this comment back?

[ltian, 2016-10-03 23:56:30]

The CQ bit was checked by ltian@chromium.org

[ltian, 2016-10-03 23:56:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2391753002/#ps40001
(title: "Add comment.")

[commit-bot: I haz the power, 2016-10-03 23:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 01:36:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 01:40:54]

Description was changed from

==========
[Android] Fix search engine page crash when users change language

When changeing language setting of phones, Template Url Service
will be changed and unloaded. Then when search engine setting page back
to active from background, it fires a NoPointerException for popluating
the Listview when Template Url Service is still loading.

To fix that, check whether Template Url Service is already loaded before
populating UI, if not, force it to load and meanwhile, close the
fragment to prevent from crash.

BUG=652170
==========

to

==========
[Android] Fix search engine page crash when users change language

When changeing language setting of phones, Template Url Service
will be changed and unloaded. Then when search engine setting page back
to active from background, it fires a NoPointerException for popluating
the Listview when Template Url Service is still loading.

To fix that, check whether Template Url Service is already loaded before
populating UI, if not, force it to load and meanwhile, close the
fragment to prevent from crash.

BUG=652170

Committed: https://crrev.com/e8efd3e036c037831a92d41604004b61b0d9f307
Cr-Commit-Position: refs/heads/master@{#422660}
==========

[commit-bot: I haz the power, 2016-10-04 01:40:56]

Patchset 3 (id:??) landed as
https://crrev.com/e8efd3e036c037831a92d41604004b61b0d9f307
Cr-Commit-Position: refs/heads/master@{#422660}