BrowserPluginGuest::ResendEventToEmbedder should keep the same deltaUnits

BrowserPluginGuest::ResendEventToEmbedder should keep the same deltaUnits

When a nested scroller is at its scroll bounds InputHandlerProxy gets another
set of synthetic GestureScrollBegin/Update/End to scroll the parent scroller.

Before this CL, deltaUnits was not copied in GestureScrollBegin but was copied in
GestureScrollUpdate. As a result, InputHandlerProxy would expect an instant scroll
after GestureScrollBegin, but perform a smooth scroll in GestureScrollUpdate.

BUG=647205
Committed: https://crrev.com/eebaccca7bd4bc2f1a9fb9eaf8dcbc9c0377064d
Cr-Commit-Position: refs/heads/master@{#422894}

[ymalik, 2016-10-03 18:02:03]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ymalik, 2016-10-03 18:05:30]

ymalik@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[wjmaclean, 2016-10-03 18:09:38]

On 2016/10/03 18:05:31, ymalik wrote:

Trying it out now ...

[wjmaclean, 2016-10-03 18:15:39]

On 2016/10/03 18:09:38, wjmaclean (ooo) wrote:
> On 2016/10/03 18:05:31, ymalik wrote:
> 
> Trying it out now ...

Works for me ... LGTM!

(Thanks for tracking this down.)

[ymalik, 2016-10-03 18:19:30]

ymalik@chromium.org changed reviewers:
+ tdresser@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:48:05]

Dry run: This issue passed the CQ dry run.

[tdresser, 2016-10-03 20:15:40]

How hard would it be to add a test for this?

[wjmaclean, 2016-10-03 20:20:40]

On 2016/10/03 20:15:40, tdresser wrote:
> How hard would it be to add a test for this?

In web_view_browsertest.cc there is a test,
WebViewGuestScrollTest.TestGuestWheelScrollsBubble that is currently disabled,
but that might serve as a model for a new test (or might even be revamped).

[tdresser, 2016-10-04 18:36:11]

LGTM, though add a TODO to add a test.

[ymalik, 2016-10-04 18:36:26]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-10-04 18:36:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
wjmaclean@chromium.org
Link to the patchset: https://codereview.chromium.org/2391643002/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-10-04 18:36:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ymalik, 2016-10-04 18:37:17]

On 2016/10/04 18:36:11, tdresser wrote:
> LGTM, though add a TODO to add a test.

I added a TODO to fix the flaky test. Once that is fixed, we will automatically
have coverage for this case.

[commit-bot: I haz the power, 2016-10-04 20:01:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 20:03:34]

Description was changed from

==========
BrowserPluginGuest::ResendEventToEmbedder should keep the same deltaUnits

When a nested scroller is at its scroll bounds InputHandlerProxy gets another
set of synthetic GestureScrollBegin/Update/End to scroll the parent scroller.

Before this CL, deltaUnits was not copied in GestureScrollBegin but was copied
in
GestureScrollUpdate. As a result, InputHandlerProxy would expect an instant
scroll
after GestureScrollBegin, but perform a smooth scroll in GestureScrollUpdate.

BUG=647205
==========

to

==========
BrowserPluginGuest::ResendEventToEmbedder should keep the same deltaUnits

When a nested scroller is at its scroll bounds InputHandlerProxy gets another
set of synthetic GestureScrollBegin/Update/End to scroll the parent scroller.

Before this CL, deltaUnits was not copied in GestureScrollBegin but was copied
in
GestureScrollUpdate. As a result, InputHandlerProxy would expect an instant
scroll
after GestureScrollBegin, but perform a smooth scroll in GestureScrollUpdate.

BUG=647205

Committed: https://crrev.com/eebaccca7bd4bc2f1a9fb9eaf8dcbc9c0377064d
Cr-Commit-Position: refs/heads/master@{#422894}
==========

[commit-bot: I haz the power, 2016-10-04 20:03:35]

Patchset 2 (id:??) landed as
https://crrev.com/eebaccca7bd4bc2f1a9fb9eaf8dcbc9c0377064d
Cr-Commit-Position: refs/heads/master@{#422894}