Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2391643002: BrowserPluginGuest::ResendEventToEmbedder should keep the same deltaUnits (Closed)
Patch Set: Add TODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 666eb2928624addf63257443bac06471965721c4..ce1aa4eca539acf6059328e5262b0b556d1d389a 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -155,6 +155,8 @@ inline blink::WebGestureEvent CreateScrollBeginForWrapping(
wrap_gesture_scroll_begin.data.scrollBegin.deltaXHint = 0;
wrap_gesture_scroll_begin.data.scrollBegin.deltaYHint = 0;
wrap_gesture_scroll_begin.resendingPluginId = gesture_event.resendingPluginId;
+ wrap_gesture_scroll_begin.data.scrollBegin.deltaHintUnits =
+ gesture_event.data.scrollUpdate.deltaUnits;
return wrap_gesture_scroll_begin;
}
@@ -168,6 +170,8 @@ inline blink::WebGestureEvent CreateScrollEndForWrapping(
wrap_gesture_scroll_end.timeStampSeconds = gesture_event.timeStampSeconds;
wrap_gesture_scroll_end.sourceDevice = gesture_event.sourceDevice;
wrap_gesture_scroll_end.resendingPluginId = gesture_event.resendingPluginId;
+ wrap_gesture_scroll_end.data.scrollEnd.deltaUnits =
+ gesture_event.data.scrollUpdate.deltaUnits;
return wrap_gesture_scroll_end;
}
@@ -1050,6 +1054,8 @@ void RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo(
gesture_event.type == blink::WebInputEvent::GestureScrollUpdate &&
gesture_event.resendingPluginId != -1 && !(*is_in_gesture_scroll);
+ // TODO(crbug.com/544782): Fix WebViewGuestScrollTest.TestGuestWheelScrolls-
+ // Bubble to test the resending logic of gesture events.
if (scroll_update_needs_wrapping) {
ForwardGestureEventWithLatencyInfo(
CreateScrollBeginForWrapping(gesture_event),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698