Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 2391633002: Use FileDescriptorWatcher in UsbDeviceHandleUsbfs. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in UsbDeviceHandleUsbfs. This allows UsbDeviceHandleUsbfs to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/80da60ef04918cb0a7f7cf3f53e6ab8be88b81c8 Cr-Commit-Position: refs/heads/master@{#422859}

Patch Set 1 #

Patch Set 2 : fix build error #

Patch Set 3 : fix build error #

Patch Set 4 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M device/usb/usb_device_handle_usbfs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_usbfs.cc View 1 2 3 6 chunks +14 lines, -25 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-04 12:53:29 UTC) #20
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-04 18:05:34 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391633002/60001
4 years, 2 months ago (2016-10-04 18:15:32 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 18:20:49 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:22:56 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/80da60ef04918cb0a7f7cf3f53e6ab8be88b81c8
Cr-Commit-Position: refs/heads/master@{#422859}

Powered by Google App Engine
This is Rietveld 408576698