Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3228)

Unified Diff: device/usb/usb_device_handle_usbfs.cc

Issue 2391633002: Use FileDescriptorWatcher in UsbDeviceHandleUsbfs. (Closed)
Patch Set: fix build error Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_device_handle_usbfs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_device_handle_usbfs.cc
diff --git a/device/usb/usb_device_handle_usbfs.cc b/device/usb/usb_device_handle_usbfs.cc
index 07ca8cbe97a02f1a3e8dd35e56b0a7cb9006eaa9..cddb2f69678982c517c90a3ac1d927da9f2ad5f2 100644
--- a/device/usb/usb_device_handle_usbfs.cc
+++ b/device/usb/usb_device_handle_usbfs.cc
@@ -17,9 +17,9 @@
#include "base/bind.h"
#include "base/cancelable_callback.h"
+#include "base/files/file_descriptor_watcher_posix.h"
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
-#include "base/message_loop/message_pump_libevent.h"
#include "base/posix/eintr_wrapper.h"
#include "base/stl_util.h"
#include "base/threading/thread_restrictions.h"
@@ -135,8 +135,7 @@ UsbTransferStatus ConvertTransferResult(int rc) {
} // namespace
class UsbDeviceHandleUsbfs::FileThreadHelper
- : public base::MessagePumpLibevent::Watcher,
- public base::MessageLoop::DestructionObserver {
+ : public base::MessageLoop::DestructionObserver {
public:
FileThreadHelper(int fd,
scoped_refptr<UsbDeviceHandleUsbfs> device_handle,
@@ -145,18 +144,17 @@ class UsbDeviceHandleUsbfs::FileThreadHelper
static void Start(std::unique_ptr<FileThreadHelper> self);
- // base::MessagePumpLibevent::Watcher overrides.
- void OnFileCanReadWithoutBlocking(int fd) override;
- void OnFileCanWriteWithoutBlocking(int fd) override;
-
// base::MessageLoop::DestructionObserver overrides.
void WillDestroyCurrentMessageLoop() override;
private:
+ // Called when |fd_| is writable without blocking.
+ void OnFileCanWriteWithoutBlocking();
+
int fd_;
scoped_refptr<UsbDeviceHandleUsbfs> device_handle_;
scoped_refptr<base::SequencedTaskRunner> task_runner_;
- base::MessagePumpLibevent::FileDescriptorWatcher file_watcher_;
+ std::unique_ptr<base::FileDescriptorWatcher::Controller> watch_controller_;
base::ThreadChecker thread_checker_;
DISALLOW_COPY_AND_ASSIGN(FileThreadHelper);
@@ -181,25 +179,21 @@ void UsbDeviceHandleUsbfs::FileThreadHelper::Start(
// Linux indicates that URBs are available to reap by marking the file
// descriptor writable.
- if (!base::MessageLoopForIO::current()->WatchFileDescriptor(
- self->fd_, true, base::MessageLoopForIO::WATCH_WRITE,
- &self->file_watcher_, self.get())) {
- USB_LOG(ERROR) << "Failed to start watching device file descriptor.";
- }
+ self->watch_controller_ = base::FileDescriptorWatcher::WatchWritable(
+ self->fd_, base::Bind(&FileThreadHelper::OnFileCanWriteWithoutBlocking,
+ base::Unretained(self.get())));
// |self| is now owned by the current message loop.
base::MessageLoop::current()->AddDestructionObserver(self.release());
}
-void UsbDeviceHandleUsbfs::FileThreadHelper::OnFileCanReadWithoutBlocking(
- int fd) {
- NOTREACHED(); // Only listening for writability.
+void UsbDeviceHandleUsbfs::FileThreadHelper::WillDestroyCurrentMessageLoop() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ delete this;
}
-void UsbDeviceHandleUsbfs::FileThreadHelper::OnFileCanWriteWithoutBlocking(
- int fd) {
+void UsbDeviceHandleUsbfs::FileThreadHelper::OnFileCanWriteWithoutBlocking() {
DCHECK(thread_checker_.CalledOnValidThread());
- DCHECK_EQ(fd_, fd);
const size_t MAX_URBS_PER_EVENT = 10;
std::vector<usbdevfs_urb*> urbs;
@@ -214,7 +208,7 @@ void UsbDeviceHandleUsbfs::FileThreadHelper::OnFileCanWriteWithoutBlocking(
if (errno == ENODEV) {
// Device has disconnected. Stop watching the file descriptor to avoid
// looping until |device_handle_| is closed.
- file_watcher_.StopWatchingFileDescriptor();
+ watch_controller_.reset();
break;
}
} else {
@@ -227,11 +221,6 @@ void UsbDeviceHandleUsbfs::FileThreadHelper::OnFileCanWriteWithoutBlocking(
base::Bind(&UsbDeviceHandleUsbfs::ReapedUrbs, device_handle_, urbs));
}
-void UsbDeviceHandleUsbfs::FileThreadHelper::WillDestroyCurrentMessageLoop() {
- DCHECK(thread_checker_.CalledOnValidThread());
- delete this;
-}
-
struct UsbDeviceHandleUsbfs::Transfer {
Transfer() = delete;
Transfer(scoped_refptr<net::IOBuffer> buffer,
« no previous file with comments | « device/usb/usb_device_handle_usbfs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698