Several small changes to new UI pages

appengine/swarming/elements/res/imp/tasklist/task-list.html

Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index 0e916f7e4f21daadb85eda94130344faebb5538c..73bc08e5d8d42490518c9077d6f2863afae3b0bf 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -136,6 +136,14 @@
                 </sort-toggle>
               </th>
 
+              <th hidden$="[[_hide('sk_revision', _columns.*)]]">
+                <span>Skia Revision</span>
+                <sort-toggle
+                    name="sk_revision"
+                    current="[[_sort]]">
+                </sort-toggle>
+              </th>
+
               <template
                     is="dom-repeat"
                     items="[[_plainColumns]]"
@@ -193,6 +201,15 @@
                   </a>
                 </td>
 
+                <td hidden$="[[_hide('sk_revision', _columns.*)]]">
+                  <a
+                      class="center"
+                      href$="[[_skLink(task)]]"
+                      target="_blank">
+                      [[_column('sk_revision',task)]]
+                  </a>
+                </td>
+
                 <template
                     is="dom-repeat"
                     items="[[_plainColumns]]"
@@ -253,6 +270,10 @@
       created_ts: humanTime("created_ts"),
       duration: humanTime("duration"),
       modified_ts: humanTime("modified_ts"),
+      sk_revision: function(task) {
+        var r = this._attribute(task, "sk_revision")[0];
+        return r.substring(0,8);
+      },
       started_ts: humanTime("started_ts"),
       state: function(task) {
         var state = this._attribute(task, "state")[0];
@@ -401,6 +422,14 @@
         this.$.page_tasks.load(url,this._auth_headers);
       },
 
+      _skLink: function(task) {
+        var r = this._attribute(task, "sk_revision")[0];
+        if (r === "none") {
+          return undefined;

[stephana, 2016/10/03 19:58:35]

who not return empty string ? 

[kjlubick, 2016/10/03 20:07:45]

Empty string is a valid "href" and so the links are clickable even though they
go nowhere.  However, false seems to do what I want, so I made it return that
instead.

[stephana, 2016/10/04 13:24:32]

Acknowledged.

+        }
+        return "https://skia.googlesource.com/skia/+/" + r;
+      },
+
       _tag: function(task, col) {
         if (!task || !task.tagMap) {
           return undefined;