Several small changes to new UI pages

appengine/swarming/elements/res/imp/botpage/bot-page.html

Index: appengine/swarming/elements/res/imp/botpage/bot-page.html
diff --git a/appengine/swarming/elements/res/imp/botpage/bot-page.html b/appengine/swarming/elements/res/imp/botpage/bot-page.html
index b44f906dfe0e950bcf38ed850eece5b20cbf172a..1e12c4a8b43e6274ad73bee3e57aea1241b1c6bb 100644
--- a/appengine/swarming/elements/res/imp/botpage/bot-page.html
+++ b/appengine/swarming/elements/res/imp/botpage/bot-page.html
@@ -78,6 +78,12 @@
         max-width: 700px;
       }
 
+      .cloud {
+        white-space: nowrap;
+        margin-bottom: 5px;
+        margin-top: auto;
+      }
+
       paper-checkbox {
         --paper-checkbox-label-color: #fff;
         --paper-checkbox-checked-color: #fff;
@@ -132,6 +138,11 @@
 
         <div class="header horizontal layout">
           <paper-input class="id_input" label="Bot id" value="{{bot_id}}"></paper-input>
+          <template is="dom-if" if="[[_cloudConsoleLink(_bot)]]">
+            <div class="vertical layout">
+              <a href$="[[_cloudConsoleLink(_bot)]]" class="cloud">Cloud Console</a>
+            </div>
+          </template>
           <button on-click="_refresh">
             <iron-icon class="refresh" icon="icons:refresh"></iron-icon>
           </button>
@@ -169,7 +180,8 @@
               <tr>
                 <td>Current Task</td>
                 <td>
-                  <a target="_blank" href$="[[_taskLink(_bot.task_id)]]">
+                  <a target="_blank" rel="noopener"
+                      href$="[[_taskLink(_bot.task_id)]]">
                     [[_task(_bot)]]
                   </a>
                 </td>
@@ -273,7 +285,12 @@
             <tbody>
               <template is="dom-repeat" items="{{_tasks}}" as="task">
                 <tr class$="[[_taskClass(task)]]">
-                  <td><a target="_blank" href$="[[_taskLink(task.task_id)]]">[[task.name]]</a></td>
+                  <td>
+                    <a target="_blank" rel="noopener"
+                        href$="[[_taskLink(task.task_id)]]">
+                      [[task.name]]
+                    </a>
+                  </td>
                   <td>[[task.human_started_ts]]</td>
                   <td title="[[task.human_completed_ts]]">[[task.human_duration]]</td>
                   <td>[[task.state]]</td>
@@ -300,9 +317,17 @@
                   <td class="message">[[event.message]]</td>
                   <td>[[event.event_type]]</td>
                   <td>[[event.human_ts]]</td>
-                  <td><a target="_blank" href$="[[_taskLink(event.task_id)]]">[[event.task_id]]</a></td>
+                  <td>
+                    <a target="_blank" rel="noopener"
+                        href$="[[_taskLink(event.task_id)]]">
+                      [[event.task_id]]
+                    </a>
+                  </td>
                   <td class$="[[_classVersion(_server_version.bot_version,event.version)]]">
-                    <a target="_blank" href$="[[_luciLink(event.version)]]">[[_shorten(event.version,'8')]]</a>
+                    <a target="_blank" rel="noopener"
+                        href$="[[_luciLink(event.version)]]">
+                      [[_shorten(event.version,'8')]]
+                    </a>
                   </td>
                 </tr>
               </template>
@@ -425,6 +450,22 @@
         this._reload();
       },
 
+      _cloudConsoleLink(bot) {

[stephana, 2016/10/03 19:58:35]

Should this be  

_cloudConsoleLink: function(bot) {

...? 

[kjlubick, 2016/10/03 20:07:45]

yes.  I'm surprised it worked.

+        // We create a link to this bot in cloud console if we detect it is
+        // on GCE.  We look for the zone dimension and create the link using
+        // that.
+        if (!bot || !bot.dimensions) {
+          return undefined;

[stephana, 2016/10/03 19:58:35]

return false or empty string instead of undefined. 

[kjlubick, 2016/10/03 20:07:45]

Done.

+        }
+        var link;
+        bot.dimensions.forEach(function(d){
+          if (d.key === "zone") {
+            link = this._cloudConsoleLink(d.value[0], bot.bot_id);

[stephana, 2016/10/03 19:58:35]

what's the second argument ? wouldn't this make a recursive call. What's the
second argument ? 

[kjlubick, 2016/10/03 20:07:45]

This was, correctly but inexplicably, calling common-behavior._cloudConsoleLink

Naming has been updated to avoid this.

[stephana, 2016/10/04 13:24:31]

Acknowledged.

+          }
+        }.bind(this))
+        return link;
+      },
+
       _concat: function(arr) {
         if (!arr) {
           return "";