chrome/ and build/ lint suppressions needed for Android SDK roll.

chrome/ and build/ lint suppressions needed for Android SDK roll.

BUG=623989
Committed: https://crrev.com/2aee2cecde130fdb5e9084d8cf432f9e69ee0f92
Cr-Commit-Position: refs/heads/master@{#423230}

[ghost stip (do not use), 2016-10-05 00:51:09]

Description was changed from

==========
chrome/ lint suppressions needed for Android SDK roll.


BUG=623989
==========

to

==========
chrome/ and build/ lint suppressions needed for Android SDK roll.


BUG=623989
==========

[ghost stip (do not use), 2016-10-05 00:51:09]

stip@chromium.org changed reviewers:
+ agrieve@chromium.org, jbudorick@chromium.org

[ghost stip (do not use), 2016-10-05 00:51:55]

ptal

These should be the last upstream lint suppressions before we can land
https://codereview.chromium.org/2350013004/

https://codereview.chromium.org/2391573006/diff/1/build/android/lint/suppress...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2391573006/diff/1/build/android/lint/suppress...
build/android/lint/suppressions.xml:308: <ignore
regexp="remoting/android/java/res/drawable-hdpi/ic_info.png"/>
I can switch this to * if that makes more sense.

[agrieve, 2016-10-05 00:58:28]

On 2016/10/05 00:51:55, stip wrote:
> ptal
> 
> These should be the last upstream lint suppressions before we can land
> https://codereview.chromium.org/2350013004/
> 
>
https://codereview.chromium.org/2391573006/diff/1/build/android/lint/suppress...
> File build/android/lint/suppressions.xml (right):
> 
>
https://codereview.chromium.org/2391573006/diff/1/build/android/lint/suppress...
> build/android/lint/suppressions.xml:308: <ignore
> regexp="remoting/android/java/res/drawable-hdpi/ic_info.png"/>
> I can switch this to * if that makes more sense.

+lambros for remoting suppression fyi.

lgtm

[Lambros, 2016-10-05 01:44:41]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2016-10-05 01:44:42]

I don't think we need that ic_info.png resource any more. I think it became
unused when Yuwei moved the Credits menu-item out of the nav-drawer into the
Help activity.
yuwei@, can you confirm?

[Yuwei, 2016-10-05 02:20:17]

On 2016/10/05 01:44:42, Lambros wrote:
> I don't think we need that ic_info.png resource any more. I think it became
> unused when Yuwei moved the Credits menu-item out of the nav-drawer into the
> Help activity.
> yuwei@, can you confirm?

Correct. I don't think it's being used anywhere else.

[ghost stip (do not use), 2016-10-05 16:09:01]

should I just delete the file instead?

[ghost stip (do not use), 2016-10-05 17:15:17]

I got a compile error when I deleted the file, so I made it into a TODO.

[ghost stip (do not use), 2016-10-05 17:15:34]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2016-10-05 17:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2391573006/#ps20001
(title: "Add TODO.")

[commit-bot: I haz the power, 2016-10-05 17:16:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lambros, 2016-10-05 17:17:46]

On 2016/10/05 16:09:01, stip wrote:
> should I just delete the file instead?

Yes, feel free to delete the drawable-*/ic_info.png files. The warning seems to
be correct in this case.

[Lambros, 2016-10-05 17:23:53]

On 2016/10/05 17:15:17, stip wrote:
> I got a compile error when I deleted the file, so I made it into a TODO.

If the error is this:
ninja: error: '../../remoting/android/java/res/drawable-hdpi/ic_info.png',
needed by
'obj/remoting/android/remoting_android_client_java_resources__process_resources.inputdeps.stamp',
missing and no known rule to make it

Then you need to re-run 'gn gen out/whatever'.

If the error is this:
remoting/android/java/res/drawable-hdpi Missing the following drawables in
`drawable-hdpi`: ic_info.png (found in drawable-xxhdpi, drawable-xhdpi,
drawable-xxxhdpi, drawable-mdpi): IconDensities [warning]

Then you need to remove all of the */ic_info.png files (and re-run 'gn gen ..')

Then it works for me :)

[commit-bot: I haz the power, 2016-10-05 17:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:25:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ghost stip (do not use), 2016-10-05 17:28:50]

stip@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ghost stip (do not use), 2016-10-05 17:28:51]

Blerg, I thought agrieve@ had OWNERS in that.

Ted, could you take a look?

[ghost stip (do not use), 2016-10-05 17:36:15]

Cool, after a `gn gen` it works fine. The uploaded patchset works fine, just
waiting on Ted's approval.

[Ted C, 2016-10-05 17:36:54]

On 2016/10/05 17:36:15, stip wrote:
> Cool, after a `gn gen` it works fine. The uploaded patchset works fine, just
> waiting on Ted's approval.

lgtm!

[ghost stip (do not use), 2016-10-05 17:37:18]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2016-10-05 17:37:19]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2391573006/#ps40001
(title: "Delete unused files.")

[commit-bot: I haz the power, 2016-10-05 17:37:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:48:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ghost stip (do not use), 2016-10-05 18:00:41]

just need OWNERS from yuwei@ or lambroslambrou@ now :)

[Yuwei, 2016-10-05 18:20:06]

yuweih@chromium.org changed reviewers:
+ yuweih@chromium.org

[Yuwei, 2016-10-05 18:20:07]

LGTM for deleting ic_info

[ghost stip (do not use), 2016-10-05 18:20:24]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:20:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:29:55]

Description was changed from

==========
chrome/ and build/ lint suppressions needed for Android SDK roll.


BUG=623989
==========

to

==========
chrome/ and build/ lint suppressions needed for Android SDK roll.


BUG=623989
==========

[commit-bot: I haz the power, 2016-10-05 18:29:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 18:33:51]

Description was changed from

==========
chrome/ and build/ lint suppressions needed for Android SDK roll.


BUG=623989
==========

to

==========
chrome/ and build/ lint suppressions needed for Android SDK roll.

BUG=623989

Committed: https://crrev.com/2aee2cecde130fdb5e9084d8cf432f9e69ee0f92
Cr-Commit-Position: refs/heads/master@{#423230}
==========

[commit-bot: I haz the power, 2016-10-05 18:33:53]

Patchset 3 (id:??) landed as
https://crrev.com/2aee2cecde130fdb5e9084d8cf432f9e69ee0f92
Cr-Commit-Position: refs/heads/master@{#423230}