Upgrade to new Android SDK.

Upgrade to new Android SDK.

BUG=623989
Committed: https://crrev.com/e3c21739bcc8d5df70d2dd011c3f575570085b6d
Cr-Commit-Position: refs/heads/master@{#425423}

[ghost stip (do not use), 2016-09-20 00:47:47]

Description was changed from

==========
Upgrade to new Android sdk.

[WIP]

BUG=623989
==========

to

==========
Upgrade to new Android SDK.

[WIP]

BUG=623989
==========

[ghost stip (do not use), 2016-10-05 18:01:23]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:02:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:23:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ghost stip (do not use), 2016-10-05 21:04:46]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:05:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 21:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:30:17]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ghost stip (do not use), 2016-10-05 21:40:26]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:10:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:10:04]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[ghost stip (do not use), 2016-10-07 18:15:47]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ghost stip (do not use), 2016-10-07 18:16:21]

Description was changed from

==========
Upgrade to new Android SDK.

[WIP]

BUG=623989
==========

to

==========
Upgrade to new Android SDK.

BUG=623989
==========

[ghost stip (do not use), 2016-10-07 18:16:21]

stip@chromium.org changed reviewers:
+ jbudorick@chromium.org, xunjieli@chromium.org

[ghost stip (do not use), 2016-10-07 18:17:25]

jbudorick: ptal!
xunjieli: cronet OWNERS

[commit-bot: I haz the power, 2016-10-07 18:44:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:44:03]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[xunjieli, 2016-10-07 19:24:13]

> xunjieli: cronet OWNERS
lgtm

[xunjieli, 2016-10-07 19:24:15]

> xunjieli: cronet OWNERS
lgtm

[ghost stip (do not use), 2016-10-12 23:35:39]

stip@chromium.org changed reviewers:
+ agrieve@chromium.org

[ghost stip (do not use), 2016-10-12 23:35:46]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 23:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:57:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:57:01]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ghost stip (do not use), 2016-10-13 00:55:58]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 00:56:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ghost stip (do not use), 2016-10-13 00:56:16]

The CQ bit was unchecked by stip@chromium.org

[ghost stip (do not use), 2016-10-13 01:01:35]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 01:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-10-13 01:15:53]

On 2016/10/07 19:24:15, xunjieli wrote:
> > xunjieli: cronet OWNERS
> lgtm

lgtm - I'd like to wait for downstream:
https://chrome-internal-review.googlesource.com/#/c/295616/ to land before
submitting this though in order to avoid breaking the auto-roller. If trybots
pass, I can click the submit button tomorrow morning EST, which might be a
better time of day anyways this change.

[commit-bot: I haz the power, 2016-10-13 01:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 01:21:18]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ghost stip (do not use), 2016-10-13 07:17:41]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:18:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ghost stip (do not use), 2016-10-13 08:18:14]

Looks like everything passes except for a findbugs error on
android_clang_dbg_recipe (a new one this time!)

https://codereview.chromium.org/2350013004/diff/280001/build/android/lint/sup...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2350013004/diff/280001/build/android/lint/sup...
build/android/lint/suppressions.xml:222: <ignore
regexp="org/chromium/content/browser/input/ReplicaInputConnection.class"/>
we can put these in the code (with OWNERS approval) after landing

https://codereview.chromium.org/2350013004/diff/280001/build/android/lint/sup...
build/android/lint/suppressions.xml:294: <issue id="UnusedResources"
severity="ignore"/>
I suspect this will be quite unpopular, but I think it's necessary at this
point. We can unto with a more targetted suppression once the N SDK lands.

https://codereview.chromium.org/2350013004/diff/280001/build/android/lint/sup...
build/android/lint/suppressions.xml:383: <ignore
regexp="ui/android/java/res/values/dimens.xml"/>
just a sampling of the new errors I hit before giving up with the global
override

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
File components/cronet/tools/generate_javadoc.py (right):

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
components/cronet/tools/generate_javadoc.py:46: # TODO(stip): add 'or "warning"'
back once compiler situation is resolved.
xunjieli: FYI

[commit-bot: I haz the power, 2016-10-13 09:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 09:23:53]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[xunjieli, 2016-10-13 13:45:57]

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
File components/cronet/tools/generate_javadoc.py (right):

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
components/cronet/tools/generate_javadoc.py:46: # TODO(stip): add 'or "warning"'
back once compiler situation is resolved.
On 2016/10/13 08:18:14, stip wrote:
> xunjieli: FYI

Could you link a bug number here so we can track it on our side? Thanks

[ghost stip (do not use), 2016-10-13 15:56:01]

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
File components/cronet/tools/generate_javadoc.py (right):

https://codereview.chromium.org/2350013004/diff/280001/components/cronet/tool...
components/cronet/tools/generate_javadoc.py:46: # TODO(stip): add 'or "warning"'
back once compiler situation is resolved.
On 2016/10/13 13:45:57, xunjieli wrote:
> On 2016/10/13 08:18:14, stip wrote:
> > xunjieli: FYI
> 
> Could you link a bug number here so we can track it on our side? Thanks

Done!

[xunjieli, 2016-10-13 16:21:01]

lgtm

[ghost stip (do not use), 2016-10-14 00:59:42]

The CQ bit was checked by stip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:00:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 03:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 03:06:17]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[agrieve, 2016-10-14 17:57:41]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:58:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:41:35]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-10-14 19:09:30]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-10-14 19:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2350013004/#ps300001
(title: "Add crbug for cronet TODO.")

[commit-bot: I haz the power, 2016-10-14 19:09:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:21:44]

Description was changed from

==========
Upgrade to new Android SDK.

BUG=623989
==========

to

==========
Upgrade to new Android SDK.

BUG=623989
==========

[commit-bot: I haz the power, 2016-10-14 19:21:46]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-10-14 19:24:46]

Description was changed from

==========
Upgrade to new Android SDK.

BUG=623989
==========

to

==========
Upgrade to new Android SDK.

BUG=623989

Committed: https://crrev.com/e3c21739bcc8d5df70d2dd011c3f575570085b6d
Cr-Commit-Position: refs/heads/master@{#425423}
==========

[commit-bot: I haz the power, 2016-10-14 19:24:47]

Patchset 16 (id:??) landed as
https://crrev.com/e3c21739bcc8d5df70d2dd011c3f575570085b6d
Cr-Commit-Position: refs/heads/master@{#425423}

[nednguyen, 2016-10-17 00:23:57]

A revert of this CL (patchset #16 id:300001) has been created in
https://codereview.chromium.org/2425563002/ by nednguyen@google.com.

The reason for reverting is: This may have changed the adb used by
adb_logcat_monitor.py  & creates a conflict with the one used by telemetry.

BUG=656224.