include/v8.h - Issue 23914004: invert Eternal::IsEmpty logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 23914004: invert Eternal::IsEmpty logic (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 53e5929bd43646e1abb9344a11945a5ecbe89e0e..ba4d19b01d45bba7981f4849eafcd81acc49ad37 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -458,7 +458,7 @@ template <class T> class Eternal {

}

// Can only be safely called if already set.

V8_INLINE(Local<T> Get(Isolate* isolate));

- V8_INLINE(bool IsEmpty()) { return index_ != kInitialValue; }

+ V8_INLINE(bool IsEmpty()) { return index_ == kInitialValue; }

template<class S>

V8_INLINE(void Set(Isolate* isolate, Local<S> handle));

« no previous file with comments | « no previous file | test/cctest/test-global-handles.cc » ('j') | no next file with comments »