Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: test/cctest/test-global-handles.cc

Issue 23914004: invert Eternal::IsEmpty logic (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-global-handles.cc
diff --git a/test/cctest/test-global-handles.cc b/test/cctest/test-global-handles.cc
index d3fc25c7d718e61542f5412fec1bc7015673607b..1d33a8c86b7c9581949a33df1698b8d6f652d339 100644
--- a/test/cctest/test-global-handles.cc
+++ b/test/cctest/test-global-handles.cc
@@ -338,9 +338,9 @@ TEST(EternalHandles) {
eternal_handles->Create(
isolate, *v8::Utils::OpenHandle(*object), &indices[i]);
// Create with external api
- CHECK(!eternals[i].IsEmpty());
- eternals[i].Set(v8_isolate, object);
CHECK(eternals[i].IsEmpty());
+ eternals[i].Set(v8_isolate, object);
+ CHECK(!eternals[i].IsEmpty());
}
isolate->heap()->CollectAllAvailableGarbage();
@@ -370,7 +370,7 @@ TEST(EternalHandles) {
HandleScope scope(isolate);
v8::Local<v8::Object> object = v8::Object::New();
v8::Eternal<v8::Object> eternal(v8_isolate, object);
- CHECK(eternal.IsEmpty());
+ CHECK(!eternal.IsEmpty());
CHECK(object == eternal.Get(v8_isolate));
}
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698