Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 23914004: invert Eternal::IsEmpty logic (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-global-handles.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-04 08:16:46 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-04 08:18:41 UTC) #2
dcarney
7 years, 3 months ago (2013-09-04 08:19:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698