Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2391393002: Harmony - Use FocusableBorder for comboboxes on Mac (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index cc474726ba960ea528b48f698a89ba36e401370c..1d4ba52a31db5253ca124e04c36a74950dbbdf60 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -768,7 +768,7 @@ void Combobox::ButtonPressed(Button* sender, const ui::Event& event) {
void Combobox::UpdateBorder() {
std::unique_ptr<FocusableBorder> border(
- PlatformStyle::CreateComboboxBorder());
+ UseMd() ? new FocusableBorder() : PlatformStyle::CreateComboboxBorder());
Elly Fong-Jones 2016/10/06 14:15:36 this won't build - FocusableBorder* and unique_ptr
Evan Stade 2016/10/06 15:51:08 good call, fixed. It also occurs to me we probabl
if (style_ == STYLE_ACTION)
border->SetInsets(5, 10, 5, 10);
if (invalid_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698