Harmony - Use FocusableBorder for comboboxes on Mac

ui/views/controls/combobox/combobox.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/combobox/combobox.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 750 matching lines @@
     if (event.IsKeyEvent())
       source_type = ui::MENU_SOURCE_KEYBOARD;
     else if (event.IsGestureEvent() || event.IsTouchEvent())
       source_type = ui::MENU_SOURCE_TOUCH;
     ShowDropDownMenu(source_type);
   }
 }
 
 void Combobox::UpdateBorder() {
   std::unique_ptr<FocusableBorder> border(
-      PlatformStyle::CreateComboboxBorder());
+      UseMd() ? new FocusableBorder() : PlatformStyle::CreateComboboxBorder());

[Elly Fong-Jones, 2016/10/06 14:15:36]

this won't build - FocusableBorder* and unique_ptr<FocusableBorder> don't match

[Evan Stade, 2016/10/06 15:51:08]

good call, fixed.

It also occurs to me we probably don't want a different BG on mac, right? Since
for whatever reason we are only setting that in the UseMd case, we can go ahead
and ditch the mac combobox bg, yes? I've made that change as well, ptal.

   if (style_ == STYLE_ACTION)
     border->SetInsets(5, 10, 5, 10);
   if (invalid_)
     border->SetColor(gfx::kGoogleRed700);
   SetBorder(std::move(border));
 }
 
 void Combobox::AdjustBoundsForRTLUI(gfx::Rect* rect) const {
   rect->set_x(GetMirroredXForRect(*rect));
 }
@@ skipping 215 matching lines @@
   const int kMdPaddingWidth = 8;
   int arrow_pad = UseMd() ? kMdPaddingWidth
                           : PlatformStyle::kComboboxNormalArrowPadding;
   int padding = style_ == STYLE_NORMAL
                     ? arrow_pad * 2
                     : kActionLeftPadding + kActionRightPadding;
   return ArrowSize().width() + padding;
 }
 
 }  // namespace views