Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com

Committed: https://crrev.com/9942278f26cdbae264501e6ec4d7110018035a1e
Cr-Commit-Position: refs/heads/master@{#423699}

[f(malita), 2016-10-05 19:07:35]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:08:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-05 19:12:58]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-05 19:29:41]

Description was changed from

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

WIP

BUG=
==========

to

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to resurrect the original clip & matrix.

BUG=skia:5773
==========

[f(malita), 2016-10-05 19:36:43]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-05 19:58:42]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 21:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:09:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[f(malita), 2016-10-06 16:52:10]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 16:52:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-10-06 17:42:10]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2016-10-06 18:11:53]

Description was changed from

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to resurrect the original clip & matrix.

BUG=skia:5773
==========

to

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
==========

[f(malita), 2016-10-06 18:22:29]

Description was changed from

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
==========

to

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com
==========

[f(malita), 2016-10-06 18:22:29]

fmalita@chromium.org changed reviewers:
+ junov@chromium.org, reed@google.com

[f(malita), 2016-10-06 18:23:03]

This feels a bit fragile due to non-localized canvas initialization, but
hopefully the ASSERTS should catch any issues.  WDYT?

[Justin Novosad, 2016-10-06 19:48:55]

lgtm with nits

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:161: #if
ENABLE(ASSERT)
should be DCHECK_IS_ON()

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:294: #if
ENABLE(ASSERT)
DCHECK_IS_ON()

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp:70: #if
ENABLE(ASSERT)
DCHECK_IS_ON()

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:209:
#if ENABLE(ASSERT)
DCHECK_IS_ON()

[f(malita), 2016-10-06 20:02:30]

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:161: #if
ENABLE(ASSERT)
On 2016/10/06 19:48:54, Justin Novosad wrote:
> should be DCHECK_IS_ON()

Done.

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:294: #if
ENABLE(ASSERT)
On 2016/10/06 19:48:54, Justin Novosad wrote:
> DCHECK_IS_ON()

Done.

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp:70: #if
ENABLE(ASSERT)
On 2016/10/06 19:48:54, Justin Novosad wrote:
> DCHECK_IS_ON()

Done.

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2391373002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:209:
#if ENABLE(ASSERT)
On 2016/10/06 19:48:54, Justin Novosad wrote:
> DCHECK_IS_ON()

Done.

[f(malita), 2016-10-06 20:02:36]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-10-06 20:02:36]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2391373002/#ps120001
(title: "review")

[commit-bot: I haz the power, 2016-10-06 20:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:50:30]

Description was changed from

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com
==========

to

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com
==========

[commit-bot: I haz the power, 2016-10-06 21:50:32]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-06 21:52:04]

Description was changed from

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com
==========

to

==========
Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Skia is considering removing the SkCanvas APIs which allow mutating
the state in a non-additive manner:
setMatrix() & clip{Rect,RRect,Path}(kReplace_Op).

CanvasRenderingContext2D uses the above to reset the canvas state to the
initial clip and identity matrix.

The same can be achieved with an initial unbalanced save() frame, and
a restore/save pair in reset(), to reinstate the original clip & matrix.

BUG=skia:5773
R=junov@chromium.org,reed@google.com

Committed: https://crrev.com/9942278f26cdbae264501e6ec4d7110018035a1e
Cr-Commit-Position: refs/heads/master@{#423699}
==========

[commit-bot: I haz the power, 2016-10-06 21:52:05]

Patchset 7 (id:??) landed as
https://crrev.com/9942278f26cdbae264501e6ec4d7110018035a1e
Cr-Commit-Position: refs/heads/master@{#423699}