third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp - Issue 2391373002: Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

Issue 2391373002: Refactor CRC2D::reset() to avoid non-additive SkCanvas state operations (Closed)

Patch Set: review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp ('k') | third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

index 2b9a2c6b1a3dc92ba0f6decbc75549b716983ad1..cbdbd570fbf01f9ad8c1f63714fef6fad560e204 100644

--- a/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

@@ -52,6 +52,11 @@ UnacceleratedImageBufferSurface::UnacceleratedImageBufferSurface(

m_surface =

SkSurface::MakeRaster(info, Opaque == opacityMode ? 0 : &disableLCDProps);

+ // Always save an initial frame, to support resetting the top level matrix

+ // and clip.

+ if (m_surface)

+ m_surface->getCanvas()->save();

if (initializationMode == InitializeImagePixels) {

if (m_surface)

clear();