Use mojo Shelf interfaces for both mash and classic ash.

chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_
 
+#include <memory>
 #include <string>
 #include <vector>
 
 #include "ash/common/shelf/shelf_item_delegate.h"
 #include "ash/common/shelf/shelf_item_types.h"
+#include "ash/public/interfaces/shelf.mojom.h"
 #include "base/memory/scoped_vector.h"
+#include "chrome/browser/ui/app_icon_loader.h"
+#include "chrome/browser/ui/app_icon_loader_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_types.h"
 #include "chrome/browser/ui/ash/launcher/settings_window_observer.h"
 #include "extensions/common/constants.h"
+#include "mojo/public/cpp/bindings/associated_binding.h"
 
 class AccountId;
 class ArcAppDeferredLauncherController;
 class Browser;
 class BrowserShortcutLauncherItemController;
 class GURL;
+class LauncherControllerHelper;
 class LauncherItemController;
 
 namespace ash {
 class WmShelf;
 }
 
 namespace content {
 class WebContents;
 }
 
 namespace gfx {
 class Image;
 }
 
 namespace ui {
 class BaseWindow;
 }
 
 // A list of the elements which makes up a simple menu description.
 typedef ScopedVector<ChromeLauncherAppMenuItem> ChromeLauncherAppMenuItems;
 
 // ChromeLauncherController manages the launcher items needed for content
 // windows. Launcher items have a type, an optional app id, and a controller.
-// There are different kinds of launcher item controllers, all extending the
-// LauncherItemController class.
-class ChromeLauncherController {
+// Implements mojom::ShelfObserver and is a client of mojom::ShelfController.
+class ChromeLauncherController : public ash::mojom::ShelfObserver,
+                                 private AppIconLoaderDelegate {

[sky, 2016/10/07 16:10:18]

private->public

[msw, 2016/10/07 22:45:58]

Done.

  public:
   // Used to update the state of non plaform apps, as web contents change.
   enum AppState {
     APP_STATE_ACTIVE,
     APP_STATE_WINDOW_ACTIVE,
     APP_STATE_INACTIVE,
     APP_STATE_REMOVED
   };
 
   // Set the ChromeLauncherController singleton.
   static void set_instance(ChromeLauncherController* instance) {

[sky, 2016/10/07 16:10:18]

optional/future: nuke this and set in constructor?

[msw, 2016/10/07 22:45:58]

Done. Also removed the CreateInstance static methods and MashInit(), etc.

     instance_ = instance;
   }
 
   // Returns the single ChromeLauncherController instance.
   static ChromeLauncherController* instance() { return instance_; }
 
-  virtual ~ChromeLauncherController();
+  Profile* profile() const { return profile_; }
+
+  LauncherControllerHelper* launcher_controller_helper() {
+    return launcher_controller_helper_.get();
+  }
+
+  ~ChromeLauncherController() override;
 
   // Initializes this ChromeLauncherController.
   virtual void Init() = 0;
 
   // Creates a new app item on the shelf for |controller|.
   virtual ash::ShelfID CreateAppLauncherItem(LauncherItemController* controller,
                                              const std::string& app_id,
                                              ash::ShelfItemStatus status) = 0;
 
   // Updates the running status of an item. It will also update the status of
@@ skipping 43 matching lines @@
   virtual void Close(ash::ShelfID id) = 0;
 
   // Returns true if the specified item is open.
   virtual bool IsOpen(ash::ShelfID id) = 0;
 
   // Returns true if the specified item is for a platform app.
   virtual bool IsPlatformApp(ash::ShelfID id) = 0;
 
   // Opens a new instance of the application identified by |app_id|.
   // Used by the app-list, and by pinned-app shelf items.
-  virtual void LaunchApp(const std::string& app_id,
-                         ash::LaunchSource source,
-                         int event_flags) = 0;
+  void LaunchApp(const std::string& app_id,
+                 ash::LaunchSource source,
+                 int event_flags);
 
   // If |app_id| is running, reactivates the app's most recently active window,
   // otherwise launches and activates the app.
   // Used by the app-list, and by pinned-app shelf items.
   virtual void ActivateApp(const std::string& app_id,
                            ash::LaunchSource source,
                            int event_flags) = 0;
 
   // Returns the launch type of app for the specified id.
   virtual extensions::LaunchType GetLaunchType(ash::ShelfID id) = 0;
 
   // Set the image for a specific shelf item (e.g. when set by the app).
   virtual void SetLauncherItemImage(ash::ShelfID shelf_id,
                                     const gfx::ImageSkia& image) = 0;
 
   // Find out if the given application |id| is a windowed app item and not a
   // pinned item in the shelf.
   virtual bool IsWindowedAppInLauncher(const std::string& app_id) = 0;
 
   // Updates the launch type of the app for the specified id to |launch_type|.
   virtual void SetLaunchType(ash::ShelfID id,
                              extensions::LaunchType launch_type) = 0;
 
-  // Accessor to the currently loaded profile. Note that in multi profile use
-  // cases this might change over time.
-  virtual Profile* GetProfile() = 0;
-
   // Notify the controller that the state of an non platform app's tabs
   // have changed,
   virtual void UpdateAppState(content::WebContents* contents,
                               AppState app_state) = 0;
 
   // Returns ShelfID for |contents|. If |contents| is not an app or is not
   // pinned, returns the id of browser shrotcut.
   virtual ash::ShelfID GetShelfIDForWebContents(
       content::WebContents* contents) = 0;
 
@@ skipping 65 matching lines @@
   virtual bool ShelfBoundsChangesProbablyWithUser(
       ash::WmShelf* shelf,
       const AccountId& account_id) const = 0;
 
   // Called when the user profile is fully loaded and ready to switch to.
   virtual void OnUserProfileReadyToSwitch(Profile* profile) = 0;
 
   // Controller to launch Arc apps in deferred mode.
   virtual ArcAppDeferredLauncherController* GetArcDeferredLauncher() = 0;
 
+  AppIconLoader* GetAppIconLoaderForApp(const std::string& app_id);
+
+  // Sets the shelf auto-hide and/or alignment behavior from prefs.
+  void SetShelfAutoHideBehaviorFromPrefs();
+  void SetShelfAlignmentFromPrefs();
+  void SetShelfBehaviorsFromPrefs();
+
+  // Sets LauncherControllerHelper or AppIconLoader for test, taking ownership.
+  void SetLauncherControllerHelperForTest(
+      std::unique_ptr<LauncherControllerHelper> helper);
+  void SetAppIconLoadersForTest(
+      std::vector<std::unique_ptr<AppIconLoader>>& loaders);
+
+  void SetProfileForTest(Profile* profile);
+
  protected:
   ChromeLauncherController();
 
+  // Connects or reconnects to the mojom::ShelfController interface in ash.
+  // Returns true if connected and returns false in unit tests.
+  bool ConnectToShelfController();
+
+  // Accessor for subclasses to interact with the shelf controller.
+  ash::mojom::ShelfControllerPtr& shelf_controller() {
+    return shelf_controller_;
+  }
+
+  // Attach to a specific profile.
+  virtual void AttachProfile(Profile* profile);
+
+  // ash::mojom::ShelfObserver:
+  void OnShelfCreated(int64_t display_id) override;
+  void OnAlignmentChanged(ash::ShelfAlignment alignment,
+                          int64_t display_id) override;
+  void OnAutoHideBehaviorChanged(ash::ShelfAutoHideBehavior auto_hide,
+                                 int64_t display_id) override;
+
  private:
+  // AppIconLoaderDelegate:
+  void OnAppImageUpdated(const std::string& app_id,
+                         const gfx::ImageSkia& image) override;
+
   static ChromeLauncherController* instance_;
 
+  // The currently loaded profile used for prefs and loading extensions. This is
+  // NOT necessarily the profile new windows are created with. Note that in
+  // multi-profile use cases this might change over time.
+  Profile* profile_;
+
+  // Ash's mojom::ShelfController used to change shelf state.
+  ash::mojom::ShelfControllerPtr shelf_controller_;
+
+  // The binding this instance uses to implment mojom::ShelfObserver
+  mojo::AssociatedBinding<ash::mojom::ShelfObserver> observer_binding_;
+
+  // Used to get app info for tabs.
+  std::unique_ptr<LauncherControllerHelper> launcher_controller_helper_;
+
+  // An observer that manages the shelf title and icon for settings windows.
   SettingsWindowObserver settings_window_observer_;
 
+  // Used to load the images for app items.
+  std::vector<std::unique_ptr<AppIconLoader>> app_icon_loaders_;
+
   DISALLOW_COPY_AND_ASSIGN(ChromeLauncherController);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_H_