Site Settings Desktop: Polish the Site Data section.

Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/911a4d605e2c485c0cc9547b084a9a3bd3c2e495
Cr-Commit-Position: refs/heads/master@{#424127}

[Finnur, 2016-10-05 12:15:51]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

BUG=652558
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-05 12:15:54]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 12:16:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 13:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 13:11:16]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-10-05 13:32:53]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 13:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-05 13:35:41]

Patchset #2 (id:20001) has been deleted

[Finnur, 2016-10-05 13:37:09]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-05 13:41:08]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all or for a single site (both on the Cookie page
  and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-05 13:42:06]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all or for a single site (both on the Cookie page
  and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-05 13:42:06]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[Finnur, 2016-10-05 13:42:18]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[Finnur, 2016-10-05 13:42:22]

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/cookie_tree_node.js
(right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:247:
'padding-top: 7px;';
I'd like to do the styling in the html section for the polymer object
(site_data_details_dialog.html), but I was unsuccessful in setting a class name
here and then style it via the html/css. If you have tips I'd gladly accept
them.

[commit-bot: I haz the power, 2016-10-05 13:42:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 14:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:54:53]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-05 22:04:02]

https://codereview.chromium.org/2391253002/diff/40001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1818: <message
name="IDS_SETTINGS_SITE_SETTINGS_SITE_DELETE" desc="Text for the button that
clears all site data.">
line 1818 and 1815 seem to have the same desc 
text. Should one of them be different?

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/cookie_tree_node.js
(right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:247:
'padding-top: 7px;';
On 2016/10/05 13:42:22, Finnur wrote:
> I'd like to do the styling in the html section for the polymer object
> (site_data_details_dialog.html), but I was unsuccessful in setting a class
name
> here and then style it via the html/css. If you have tips I'd gladly accept
> them.

Let's call the above Option A.

Here's Option B:

How about using a dom-repeat to fill in the data.
There's an example at CL 2395883003 that could
be diff'd against this CL.
https://codereview.chromium.org/2395883003/

In that CL, I changed the addCookieData (that returned 
HTML elements) to a getCookieData that returns an array
of objects to expand in the dom-repeat.

I also made some changes to the shared css to make
it easier to style this list. Some of the styles 
were scoped within .settings-box or similar and I
don't think that's necessary (now that I'm more
experienced with shadow dom than I was when I scoped
those css classes).

Option C

Another option would be to create a dom-module that
is the list of cookie data. This would essentially
add another level of shadow dom and move the dom-repeat
to a separate file. 

My thoughts:

I like Option B or C. Option B is a little leaner
while Option C has better code encapsulation. So
there's just a trade-off there (i.e. someone
will say Option B is better than Option C; and vice
versa).

It's hard for me to know if I'm explaining this well,
please let me know if I could/should provide more
details.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.html:43: </div>
You're welcome to unwrap lines 41 to 43. Just 
mentioning it, it's your call.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/cookies_view_handler.cc (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/cookies_view_handler.cc:151: parent_node, start,
count, true, children.get());
Let's name the boolean like this:
, /*include_quota_nodes=*/true,

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/cookies_view_handler.cc:269:
model_util_->GetChildNodeList(parent, 0, parent->child_count(), true,
/*start=*/0,
...
/*include_quota_nodes=*/true,

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1413:
IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_DIALOG_TITLE},
This is were I might make a note about
sorting the entries, but it looks like
the entries are not sorted to begin with,
so I feel funny about suggesting they 
get sorted. Maybe sort the new entries
relative to each other(?). Dunno, this is
optional.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc:95:
parent_node, start, count, false, children.get());
/*include_quota_nodes=*/false,

[Finnur, 2016-10-07 14:50:54]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 14:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-07 14:58:16]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 14:58:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-10-07 14:58:59]

Patchset #3 (id:60001) has been deleted

[Finnur, 2016-10-07 15:16:42]

https://codereview.chromium.org/2391253002/diff/40001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1818: <message
name="IDS_SETTINGS_SITE_SETTINGS_SITE_DELETE" desc="Text for the button that
clears all site data.">
On 2016/10/05 22:04:02, dschuyler wrote:
> line 1818 and 1815 seem to have the same desc 
> text. Should one of them be different?

Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/cookie_tree_node.js
(right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:247:
'padding-top: 7px;';
I love it. Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.html:43: </div>
On 2016/10/05 22:04:02, dschuyler wrote:
> You're welcome to unwrap lines 41 to 43. Just 
> mentioning it, it's your call.

Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/cookies_view_handler.cc (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/cookies_view_handler.cc:151: parent_node, start,
count, true, children.get());
On 2016/10/05 22:04:02, dschuyler wrote:
> Let's name the boolean like this:
> , /*include_quota_nodes=*/true, 

Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/cookies_view_handler.cc:269:
model_util_->GetChildNodeList(parent, 0, parent->child_count(), true,
On 2016/10/05 22:04:02, dschuyler wrote:
> /*start=*/0,
> ...
> /*include_quota_nodes=*/true,

Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1413:
IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE_DIALOG_TITLE},
On 2016/10/05 22:04:02, dschuyler wrote:
> This is were I might make a note about
> sorting the entries, but it looks like
> the entries are not sorted to begin with,
> so I feel funny about suggesting they 
> get sorted. Maybe sort the new entries
> relative to each other(?). Dunno, this is
> optional.

Done.

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc (right):

https://codereview.chromium.org/2391253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc:95:
parent_node, start, count, false, children.get());
On 2016/10/05 22:04:02, dschuyler wrote:
> /*include_quota_nodes=*/false,

Done.

[commit-bot: I haz the power, 2016-10-07 16:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 16:33:56]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dschuyler, 2016-10-07 21:14:49]

LGTM because the comments are small or optional.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/cookie_tree_node.js
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:237: var out
= [];
Let's put a @type on this.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:245: var
entry = {};
I think we can set the type on this like
/** @type{CookieDataForDisplay} */
var entry = {};

Or,
var entry = /** @type{CookieDataForDisplay} */({});

Or,
var entry = /** @type{CookieDataForDisplay} */({
  label: loadTimeData.getString(field[1]),
  content: item.data_[key],
});

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.js (right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:169: 
@param ... event (Or remove the parameter)
@private

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:176: 
@param ... event (Or remove the parameter)
@private

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_dialog.js:128:
// In with the new...
Heh, the comment seems lost without the
comment above. Maybe remove it.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:47: 
Optional: /** @override */
I don't think it's actually enforced (thus the
optional note), but it may be someday. :)

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:90:
onConfirmClearStorage_: function(event) {
Optional: it seems common to leave off the
parameter when it's not referenced in the
function. I don't think it's in the style 
guide, so I'm just throwing it out there as
an option (and the on.*_ functions above and
below this don't have event parameters).

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:108: * @private
@param ... event

and:
Should the function have a trailing underscore
'onUsageDeleted_' or should the @private be removed?

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1448:
{"siteSettingsCookieClearAll", IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE},
nit: IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE
and IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE each
sound like they will remove one cookie. Maybe
IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE could be
IDS_SETTINGS_SITE_SETTINGS_COOKIES_DELETE or
IDS_SETTINGS_SITE_SETTINGS_COOKIE_CLEAR_ALL or
IDS_SETTINGS_SITE_SETTINGS_COOKIES_CLEAR_ALL

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1464:
{"siteSettingsSiteClearAll", IDS_SETTINGS_SITE_SETTINGS_SITE_DELETE},
Similar note to above. The _DELETE suffix doesn't (to me)
convey the 'clear all' meaning.

[Finnur, 2016-10-10 09:56:56]

All done. Checking in.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/cookie_tree_node.js
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:237: var out
= [];
On 2016/10/07 21:14:48, dschuyler wrote:
> Let's put a @type on this.

Done.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/cookie_tree_node.js:245: var
entry = {};
I like the last one. Done.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.js (right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:169: 
Removed.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:176: 
Removed.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data_details_dialog.js:128:
// In with the new...
Indeed. Removed.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:47: 
Done (for all .js files in this CL)

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:90:
onConfirmClearStorage_: function(event) {
Removed.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:108: * @private
Added @param and trailing underscore.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1448:
{"siteSettingsCookieClearAll", IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE},
On 2016/10/07 21:14:49, dschuyler wrote:
> nit: IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE
> and IDS_SETTINGS_SITE_SETTINGS_COOKIE_REMOVE each
> sound like they will remove one cookie. Maybe
> IDS_SETTINGS_SITE_SETTINGS_COOKIE_DELETE could be
> IDS_SETTINGS_SITE_SETTINGS_COOKIES_DELETE or
> IDS_SETTINGS_SITE_SETTINGS_COOKIE_CLEAR_ALL or
> IDS_SETTINGS_SITE_SETTINGS_COOKIES_CLEAR_ALL

Done.

https://codereview.chromium.org/2391253002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1464:
{"siteSettingsSiteClearAll", IDS_SETTINGS_SITE_SETTINGS_SITE_DELETE},
On 2016/10/07 21:14:49, dschuyler wrote:
> Similar note to above. The _DELETE suffix doesn't (to me)
> convey the 'clear all' meaning.

Done.

[Finnur, 2016-10-10 09:57:05]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-10-10 09:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2391253002/#ps100001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-10-10 09:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 10:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 10:05:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Finnur, 2016-10-10 10:29:15]

finnur@chromium.org changed reviewers:
+ bauerb@chromium.org, dbeam@chromium.org

[Finnur, 2016-10-10 10:29:44]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-10-10 10:32:07]

Adding Dan and Bernhard as TBR for a bit of plumbing that should have no
material effect on the existing Settings code (only the new implementation that
I'm adding).

Dan for cookies_view_handler.cc and Bernhard for cookies_tree_model_util.*

[Bernhard Bauer, 2016-10-10 10:39:14]

cookies_tree_model_utils LGTM; haven't looked at the other code.

[Finnur, 2016-10-10 10:48:02]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2016-10-10 10:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 10:53:19]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-10 10:53:20]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-10-10 10:55:04]

Description was changed from

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the 
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Polish the Site Data section.

- Add a 'Cookie:' prefix for the Details dialog.
- Add a confirmation dialog when deleting all cookies
  for all sites or for a single site (both on the
  Cookie page and Site Details page).
- Remove quota nodes from the Site Data list (the usage
  total specified is not accurate -- bug 642955).
  - This also takes care of the id_ error in the console.
- Make the Site Data Details dialog more like the mocks.

TBR=dbeam, bauerb
BUG=652558
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/911a4d605e2c485c0cc9547b084a9a3bd3c2e495
Cr-Commit-Position: refs/heads/master@{#424127}
==========

[commit-bot: I haz the power, 2016-10-10 10:55:05]

Patchset 4 (id:??) landed as
https://crrev.com/911a4d605e2c485c0cc9547b084a9a3bd3c2e495
Cr-Commit-Position: refs/heads/master@{#424127}