Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc

Issue 2391253002: Site Settings Desktop: Polish the Site Data section. (Closed)
Patch Set: Address feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
index 6881c7ee5359fcce2851a394ee4c7d80538b9fa8..076e09d2289cf7f1fcaa890cdddda2ca1308da37 100644
--- a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
@@ -88,7 +88,11 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
CookieTreeNode* parent_node = tree_model->AsNode(parent);
std::unique_ptr<base::ListValue> children(new base::ListValue);
- model_util_->GetChildNodeList(parent_node, start, count, children.get());
+ // Passing false for |include_quota_nodes| since they don't reflect reality
+ // until bug http://crbug.com/642955 is fixed and local/session storage is
+ // counted against the total.
+ model_util_->GetChildNodeList(
+ parent_node, start, count, /*include_quota_nodes=*/false, children.get());
base::DictionaryValue args;
if (parent == tree_model->GetRoot())
@@ -221,8 +225,11 @@ void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
AllowJavascript();
std::unique_ptr<base::ListValue> children(new base::ListValue);
- model_util_->GetChildNodeList(parent, 0, parent->child_count(),
- children.get());
+ // Passing false for |include_quota_nodes| since they don't reflect reality
+ // until bug http://crbug.com/642955 is fixed and local/session storage is
+ // counted against the total.
+ model_util_->GetChildNodeList(parent, /*start=*/0, parent->child_count(),
+ /*include_quota_nodes=*/false, children.get());
base::DictionaryValue args;
if (parent == cookies_tree_model_->GetRoot())
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698