Report curve types in ECDSA SSLPrivateKeys.

Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150
Committed: https://crrev.com/1c09a43037481167ab735ab4a0487cad78358f0b
Cr-Commit-Position: refs/heads/master@{#425123}

[davidben, 2016-10-05 06:06:30]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 06:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 06:41:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[davidben, 2016-10-08 06:22:03]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 06:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 07:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 07:02:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[davidben, 2016-10-08 17:49:15]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 17:49:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 18:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 18:44:25]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-10-10 23:35:38]

Description was changed from

==========
TODO description

Uploading for try jobs to start with.

BUG=
==========

to

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.

BUG=630150
==========

[davidben, 2016-10-10 23:35:39]

davidben@chromium.org changed reviewers:
+ svaldez@chromium.org

[davidben, 2016-10-10 23:36:19]

Description was changed from

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.

BUG=630150
==========

to

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150
==========

[svaldez, 2016-10-11 16:03:02]

Simplified code! lgtm

[davidben, 2016-10-11 18:38:40]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-10-11 18:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 18:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 18:41:28]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davidben, 2016-10-11 18:44:14]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 18:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-10-11 18:44:52]

davidben@chromium.org changed reviewers:
+ miguelg@chromium.org, sgurun@chromium.org

[davidben, 2016-10-11 18:44:52]

sgurun for android_webview
miguelg for chrome/browser/ui/android

[sgurun-gerrit only, 2016-10-11 20:09:06]

On 2016/10/11 18:44:52, davidben wrote:
> sgurun for android_webview
> miguelg for chrome/browser/ui/android

aw lgtm.

I am only asking because I saw ECDSA. does this have any dependency on token
binding code in WebView?

thanks,

[davidben, 2016-10-11 20:11:13]

On 2016/10/11 20:09:06, sgurun wrote:
> On 2016/10/11 18:44:52, davidben wrote:
> > sgurun for android_webview
> > miguelg for chrome/browser/ui/android
> 
> aw lgtm.
> 
> I am only asking because I saw ECDSA. does this have any dependency on token
> binding code in WebView?

Nope, no relation at all. This is just client cert stuff.

[commit-bot: I haz the power, 2016-10-11 20:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 20:29:46]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-10-13 17:17:15]

davidben@chromium.org changed reviewers:
+ tedchoc@chromium.org

[davidben, 2016-10-13 17:17:16]

+tedchoc for c/b/ui/android. I forgot to check if miguelg was OOO.

[Ted C, 2016-10-13 18:16:29]

On 2016/10/13 17:17:16, davidben wrote:
> +tedchoc for c/b/ui/android. I forgot to check if miguelg was OOO.

lgtm

[davidben, 2016-10-13 18:17:23]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-10-13 18:17:25]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/2391213002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-13 18:17:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:17:58]

Description was changed from

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150
==========

to

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150
==========

[commit-bot: I haz the power, 2016-10-13 19:18:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-13 19:20:25]

Description was changed from

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150
==========

to

==========
Report curve types in ECDSA SSLPrivateKeys.

This should make ECDSA client certificates work in TLS 1.3.
For simplicity, it puts all platforms through the same
certificate-based key metadata lookup path. This saves
code and avoids guessing based on key sizes.

BUG=630150

Committed: https://crrev.com/1c09a43037481167ab735ab4a0487cad78358f0b
Cr-Commit-Position: refs/heads/master@{#425123}
==========

[commit-bot: I haz the power, 2016-10-13 19:20:26]

Patchset 4 (id:??) landed as
https://crrev.com/1c09a43037481167ab735ab4a0487cad78358f0b
Cr-Commit-Position: refs/heads/master@{#425123}