Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: net/ssl/ssl_platform_key_util.cc

Issue 2391213002: Report curve types in ECDSA SSLPrivateKeys. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/ssl_platform_key_util.h ('k') | net/ssl/ssl_platform_key_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_platform_key_util.cc
diff --git a/net/ssl/ssl_platform_key_util.cc b/net/ssl/ssl_platform_key_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..11d833432b4b13b822ce59574d574d0706849051
--- /dev/null
+++ b/net/ssl/ssl_platform_key_util.cc
@@ -0,0 +1,107 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/ssl/ssl_platform_key_util.h"
+
+#include <openssl/bytestring.h>
+#include <openssl/ec_key.h>
+#include <openssl/evp.h>
+
+#include "base/lazy_instance.h"
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/strings/string_piece.h"
+#include "base/threading/thread.h"
+#include "crypto/openssl_util.h"
+#include "net/cert/asn1_util.h"
+#include "net/cert/x509_certificate.h"
+
+namespace net {
+
+namespace {
+
+class SSLPlatformKeyTaskRunner {
+ public:
+ SSLPlatformKeyTaskRunner() : worker_thread_("Platform Key Thread") {
+ base::Thread::Options options;
+ options.joinable = false;
+ worker_thread_.StartWithOptions(options);
+ }
+
+ ~SSLPlatformKeyTaskRunner() {}
+
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner() {
+ return worker_thread_.task_runner();
+ }
+
+ private:
+ base::Thread worker_thread_;
+
+ DISALLOW_COPY_AND_ASSIGN(SSLPlatformKeyTaskRunner);
+};
+
+base::LazyInstance<SSLPlatformKeyTaskRunner>::Leaky g_platform_key_task_runner =
+ LAZY_INSTANCE_INITIALIZER;
+
+} // namespace
+
+scoped_refptr<base::SingleThreadTaskRunner> GetSSLPlatformKeyTaskRunner() {
+ return g_platform_key_task_runner.Get().task_runner();
+}
+
+bool GetClientCertInfo(const X509Certificate* certificate,
+ SSLPrivateKey::Type* out_type,
+ size_t* out_max_length) {
+ crypto::OpenSSLErrStackTracer tracker(FROM_HERE);
+
+ std::string der_encoded;
+ base::StringPiece spki;
+ if (!X509Certificate::GetDEREncoded(certificate->os_cert_handle(),
+ &der_encoded) ||
+ !asn1::ExtractSPKIFromDERCert(der_encoded, &spki)) {
+ LOG(ERROR) << "Could not extract SPKI from certificate.";
+ return false;
+ }
+
+ CBS cbs;
+ CBS_init(&cbs, reinterpret_cast<const uint8_t*>(spki.data()), spki.size());
+ bssl::UniquePtr<EVP_PKEY> key(EVP_parse_public_key(&cbs));
+ if (!key || CBS_len(&cbs) != 0) {
+ LOG(ERROR) << "Could not parse public key.";
+ return false;
+ }
+
+ switch (EVP_PKEY_id(key.get())) {
+ case EVP_PKEY_RSA:
+ *out_type = SSLPrivateKey::Type::RSA;
+ break;
+
+ case EVP_PKEY_EC: {
+ EC_KEY* ec_key = EVP_PKEY_get0_EC_KEY(key.get());
+ int curve = EC_GROUP_get_curve_name(EC_KEY_get0_group(ec_key));
+ switch (curve) {
+ case NID_X9_62_prime256v1:
+ *out_type = SSLPrivateKey::Type::ECDSA_P256;
+ break;
+ case NID_secp384r1:
+ *out_type = SSLPrivateKey::Type::ECDSA_P384;
+ break;
+ case NID_secp521r1:
+ *out_type = SSLPrivateKey::Type::ECDSA_P384;
+ break;
+ default:
+ return false;
+ }
+ break;
+ }
+
+ default:
+ return false;
+ }
+
+ *out_max_length = EVP_PKEY_size(key.get());
+ return true;
+}
+
+} // namespace net
« no previous file with comments | « net/ssl/ssl_platform_key_util.h ('k') | net/ssl/ssl_platform_key_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698