Issue 239113010: win: When use_goma=1, favor fastbuild=1 over win_z7=1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239113010: win: When use_goma=1, favor fastbuild=1 over win_z7=1. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
scottmg

CC:
chromium-reviews, ukai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

win: When use_goma=1, favor fastbuild=1 over win_z7=1. BUG=332697 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264304

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	build/common.gypi	View	1	4 chunks	+8 lines, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

scottmg

lgtm (I predict "I can't debug any more!" threads on chromium-dev, but ... I think ...

6 years, 8 months ago (2014-04-16 20:07:09 UTC) #2

Nico

I tweaked this slightly, given trybot feedback. I now ran this locally and checked that ...

6 years, 8 months ago (2014-04-16 20:47:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/239113010/20001

6 years, 8 months ago (2014-04-16 21:05:12 UTC) #5

Message was sent while issue was closed.

Change committed as 264304