Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3465)

Unified Diff: build/common.gypi

Issue 239113010: win: When use_goma=1, favor fastbuild=1 over win_z7=1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: lolgyp Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7b0e47950f4fcc28650d512425846b8ee033ccc9..fa46caa4189f8dcfbbc03dfb12e5a541c7df209b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -283,6 +283,11 @@
# on compile-only bots).
'fastbuild%': 0,
+ # Set to 1 to force Visual C++ to use legacy debug information format /Z7.
+ # This is useful for parallel compilation tools which can't support /Zi.
+ # Only used on Windows.
+ 'win_z7%' : 0,
+
# Set to 1 to enable dcheck in release.
'dcheck_always_on%': 0,
@@ -965,6 +970,7 @@
'use_xi2_mt%':'<(use_xi2_mt)',
'image_loader_extension%': '<(image_loader_extension)',
'fastbuild%': '<(fastbuild)',
+ 'win_z7%': '<(win_z7)',
'dcheck_always_on%': '<(dcheck_always_on)',
'tracing_like_official_build%': '<(tracing_like_official_build)',
'python_ver%': '<(python_ver)',
@@ -1100,11 +1106,6 @@
# Set to 1 to enable running Android lint on java/class files.
'android_lint%': 0,
- # Set to 1 to force Visual C++ to use legacy debug information format /Z7.
- # This is useful for parallel compilation tools which can't support /Zi.
- # Only used on Windows.
- 'win_z7%' : 0,
-
# Although base/allocator lets you select a heap library via an
# environment variable, the libcmt shim it uses sometimes gets in
# the way. To disable it entirely, and switch to normal msvcrt, do e.g.
@@ -2097,8 +2098,8 @@
'chromium_win_pch': 0,
# goma doesn't support PDB yet, so win_z7=1 or fastbuild=1.
'conditions': [
- ['fastbuild==0', {
- 'win_z7': 1,
+ ['win_z7==0', {
+ 'fastbuild': 1,
}],
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698