WebUIDataSource::AddInteger (like AddBoolean/AddString)

content/public/browser/web_ui_data_source.h

Index: content/public/browser/web_ui_data_source.h
diff --git a/content/public/browser/web_ui_data_source.h b/content/public/browser/web_ui_data_source.h
index 04ddab5104a6efb816c348cbbcb0041d4ae3c2b7..5c278c5069feef7d60c6a1d02d061f78350f76c1 100644
--- a/content/public/browser/web_ui_data_source.h
+++ b/content/public/browser/web_ui_data_source.h
@@ -5,6 +5,8 @@
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_
 
+#include <stdint.h>
+
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "content/common/content_export.h"
@@ -47,6 +49,11 @@ class WebUIDataSource {
   // Adds a boolean keyed to its name to our dictionary.
   virtual void AddBoolean(const std::string& name, bool value) = 0;
 
+  // Adds a signed 32-bit integer keyed to its name to our dictionary. Larger
+  // integers may not be exactly representable in JavaScript. See
+  // MAX_SAFE_INTEGER in /v8/src/globals.h.
+  virtual void AddInteger(const std::string& name, int32_t value) = 0;

[Charlie Reis, 2016/10/06 20:47:06]

We generally don't allow adding things to content/public unless the CL also has
a use outside content/.  Can you include the use in this CL?

http://www.chromium.org/developers/content-module/content-api
"only expose methods in the public API that embedders need. If a method is only
used by other code in content, it belongs in foo_impl.h and not foo.h."

[michaelpg, 2016/10/06 21:32:04]

Are you asking me to land a usage with this CL, or are you just asking me where
it will be used?

The usage is in another CL:
https://codereview.chromium.org/2393703005/diff/1/chrome/browser/ui/webui/set...

I can land that CL first w/out AddInteger, and add that one change to this CL if
that's best.

[Charlie Reis, 2016/10/06 21:36:11]

Yes, we need to land it with a usage.  (jam@ has insisted on this in the past.)
That sounds like a good strategy to me for keeping the CLs mostly independent. 
Thanks, and sorry for the hassle.

[michaelpg, 2016/10/06 23:58:37]

Done.

+
   // Sets the path which will return the JSON strings.
   virtual void SetJsonPath(const std::string& path) = 0;