WebUIDataSource::AddInteger (like AddBoolean/AddString)

content/public/browser/web_ui_data_source.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_
 
+#include <stdint.h>
+
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "content/common/content_export.h"
 
 namespace base {
 class DictionaryValue;
 class RefCountedMemory;
 }
 
 namespace content {
@@ skipping 22 matching lines @@
   // dictionary.
   virtual void AddLocalizedString(const std::string& name, int ids) = 0;
 
   // Add strings from |localized_strings| to our dictionary.
   virtual void AddLocalizedStrings(
       const base::DictionaryValue& localized_strings) = 0;
 
   // Adds a boolean keyed to its name to our dictionary.
   virtual void AddBoolean(const std::string& name, bool value) = 0;
 
+  // Adds a signed 32-bit integer keyed to its name to our dictionary. Larger
+  // integers may not be exactly representable in JavaScript. See
+  // MAX_SAFE_INTEGER in /v8/src/globals.h.
+  virtual void AddInteger(const std::string& name, int32_t value) = 0;

[Charlie Reis, 2016/10/06 20:47:06]

We generally don't allow adding things to content/public unless the CL also has
a use outside content/.  Can you include the use in this CL?

http://www.chromium.org/developers/content-module/content-api
"only expose methods in the public API that embedders need. If a method is only
used by other code in content, it belongs in foo_impl.h and not foo.h."

[michaelpg, 2016/10/06 21:32:04]

Are you asking me to land a usage with this CL, or are you just asking me where
it will be used?

The usage is in another CL:
https://codereview.chromium.org/2393703005/diff/1/chrome/browser/ui/webui/set...

I can land that CL first w/out AddInteger, and add that one change to this CL if
that's best.

[Charlie Reis, 2016/10/06 21:36:11]

Yes, we need to land it with a usage.  (jam@ has insisted on this in the past.)
That sounds like a good strategy to me for keeping the CLs mostly independent. 
Thanks, and sorry for the hassle.

[michaelpg, 2016/10/06 23:58:37]

Done.

+
   // Sets the path which will return the JSON strings.
   virtual void SetJsonPath(const std::string& path) = 0;
 
   // Adds a mapping between a path name and a resource to return.
   virtual void AddResourcePath(const std::string& path, int resource_id) = 0;
 
   // Sets the resource to returned when no other paths match.
   virtual void SetDefaultResource(int resource_id) = 0;
 
   // Used as a parameter to GotDataCallback. The caller has to run this callback
@@ skipping 27 matching lines @@
   virtual void DisableDenyXFrameOptions() = 0;
 
   // Tells the loading code that resources are gzipped on disk. TODO(dbeam):
   // write a streaming $i18n{} replacer and remove the "DisableI18n" part.
   virtual void DisableI18nAndUseGzipForAllPaths() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_UI_DATA_SOURCE_H_