Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2391073004: fix a corner case in getBufferSubData range checking (Closed)

Created:
4 years, 2 months ago by Kai Ninomiya
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix an OBOE in getBufferSubData range checking BUG=616554 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/8a02646e95830e7c67dc884280c94b219ae13e7b Cr-Commit-Position: refs/heads/master@{#423948}

Patch Set 1 #

Patch Set 2 : change behavior in this case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Kai Ninomiya
zmo, PTAL
4 years, 2 months ago (2016-10-06 00:50:39 UTC) #3
Kai Ninomiya
Updated based on offline discussion
4 years, 2 months ago (2016-10-06 01:19:49 UTC) #5
Zhenyao Mo
On 2016/10/06 01:19:49, Kai Ninomiya wrote: > Updated based on offline discussion lgtm
4 years, 2 months ago (2016-10-07 18:33:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391073004/20001
4 years, 2 months ago (2016-10-07 18:42:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 20:08:29 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 20:10:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a02646e95830e7c67dc884280c94b219ae13e7b
Cr-Commit-Position: refs/heads/master@{#423948}

Powered by Google App Engine
This is Rietveld 408576698