third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2391073004: fix a corner case in getBufferSubData range checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2391073004: fix a corner case in getBufferSubData range checking (Closed)

Patch Set: change behavior in this case Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index 318f736275a6bf75ab5f87817a84479e61da748a..c25d28e27f90b004f440a63526522a9fe1751f3c 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -373,6 +373,9 @@ void WebGL2RenderingContextBase::getBufferSubData(GLenum target,

synthesizeGLError(GL_INVALID_VALUE, funcName, "buffer overflow");

return;

}

+ if (subByteLength == 0) {

+ return;

+ }

void* mappedData =

contextGL()->MapBufferRange(target, static_cast<GLintptr>(srcByteOffset),

« no previous file with comments | « no previous file | no next file » | no next file with comments »