Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2391023002: Two small ash fixes. (Closed)

Created:
4 years, 2 months ago by kylechar
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Two small ash fixes. Remove an unused include and fix a return value. Small things I noticed during other cleanup work. BUG=none Committed: https://crrev.com/67cebf0e0c92c3a95ff5b51e790b88acd94eeca9 Cr-Commit-Position: refs/heads/master@{#422828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ash/mus/accelerators/accelerator_controller_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/non_client_frame_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
kylechar
4 years, 2 months ago (2016-10-04 15:42:35 UTC) #4
James Cook
LGTM. Looks like you got my @google.com address.
4 years, 2 months ago (2016-10-04 15:55:34 UTC) #6
kylechar
Sorry about that!
4 years, 2 months ago (2016-10-04 16:45:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391023002/1
4 years, 2 months ago (2016-10-04 16:45:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:51:40 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:53:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67cebf0e0c92c3a95ff5b51e790b88acd94eeca9
Cr-Commit-Position: refs/heads/master@{#422828}

Powered by Google App Engine
This is Rietveld 408576698