Issue 23909002: Implement closurization of regular methods in ObjectMirror.getField in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23909002: Implement closurization of regular methods in ObjectMirror.getField in the VM. (Closed)

Created:
7 years, 3 months ago by rmacnak

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement closurization of regular methods in ObjectMirror.getField in the VM. BUG=http://dartbug.com/13001 BUG=http://dartbug.com/13002

Patch Set 1 #

Patch Set 2 : implement in vm, fix test #

Patch Set 3 : copy over API language about closurization #

Total comments: 2

Patch Set 4 : rebase #

Patch Set 5 : refactor #

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -30 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2 3 4	8 chunks	+29 lines, -25 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 2 3 4	2 chunks	+0 lines, -2 lines	0 comments	Download
	runtime/vm/flow_graph_builder.cc	View	1 2 3 4	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	3 chunks	+8 lines, -2 lines	0 comments	Download
	runtime/vm/object.cc	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/resolver.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1 2	2 chunks	+26 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/mirrors/invoke_closurization_test.dart	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Fix copy-paste errors in test. Implement in the VM. Copy API language over from the ...

7 years, 3 months ago (2013-09-04 01:05:14 UTC) #2

ahe

7 years, 3 months ago (2013-09-04 01:12:26 UTC) #3

Sorry, to tired to provide any real feedback ;-)

https://chromiumcodereview.appspot.com/23909002/diff/7001/sdk/lib/mirrors/mir...
File sdk/lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/23909002/diff/7001/sdk/lib/mirrors/mir...
sdk/lib/mirrors/mirrors.dart:354: *
Could you hold off with changing this file? I'd like to have Gilad review this
change first. We did agree this is the direction to go, but I'd like to give him
a chance to look at it.

https://chromiumcodereview.appspot.com/23909002/diff/7001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/23909002/diff/7001/tests/lib/lib.statu...
tests/lib/lib.status:123: #mirrors/invoke_closurization_test: Fail # Issue 13001
Remove this comment?

Expand Messages | Collapse Messages