[BattOr] Make BattOr able to return firmware version.

tools/battor_agent/battor_agent.h

Index: tools/battor_agent/battor_agent.h
diff --git a/tools/battor_agent/battor_agent.h b/tools/battor_agent/battor_agent.h
index 810df26936af2cf15d4c72845937aa7fac8da676..f93d660f996be98f439332f8334372ca78d0bfa9 100644
--- a/tools/battor_agent/battor_agent.h
+++ b/tools/battor_agent/battor_agent.h
@@ -43,6 +43,8 @@ class BattOrAgent : public BattOrConnection::Listener,
     virtual void OnStopTracingComplete(const std::string& trace,
                                        BattOrError error) = 0;
     virtual void OnRecordClockSyncMarkerComplete(BattOrError error) = 0;
+    virtual void OnGetVersionComplete(const char* version,

[charliea (OOO until 10-5), 2016/10/18 23:46:29]

Probably should use a const std::string& here?

[rnephew (Reviews Here), 2016/10/19 18:23:48]

Done.

+                                      BattOrError error) = 0;
   };
 
   BattOrAgent(
@@ -55,6 +57,7 @@ class BattOrAgent : public BattOrConnection::Listener,
   void StartTracing();
   void StopTracing();
   void RecordClockSyncMarker(const std::string& marker);
+  void GetVersion();
 
   // Returns whether the BattOr is able to record clock sync markers in its own
   // trace log.
@@ -85,6 +88,7 @@ class BattOrAgent : public BattOrConnection::Listener,
     START_TRACING,
     STOP_TRACING,
     RECORD_CLOCK_SYNC_MARKER,
+    GET_VERSION,
   };
 
   enum class Action {
@@ -111,6 +115,10 @@ class BattOrAgent : public BattOrConnection::Listener,
     // Actions required for recording a clock sync marker.
     SEND_CURRENT_SAMPLE_REQUEST,
     READ_CURRENT_SAMPLE,
+
+    // Actions required for checking firmware version.

[charliea (OOO until 10-5), 2016/10/18 23:46:29]

Maybe "returning the firmware version" instead of "checking firmware version"?

"checking" might indicate that this command compares it against some known good
version or something, whereas this command explicitly just returns what's
already on there.

[rnephew (Reviews Here), 2016/10/19 18:23:47]

Done.

+    SEND_GIT_HASH_REQUEST,
+    READ_GIT_HASH,
   };
 
   // Performs an action.
@@ -181,6 +189,9 @@ class BattOrAgent : public BattOrConnection::Listener,
   // The timeout that's run when an action times out.
   base::CancelableClosure timeout_callback_;
 
+  // The git hash of the BattOr firmware.
+  char* git_hash_;
+
   DISALLOW_COPY_AND_ASSIGN(BattOrAgent);
 };