[BattOr] Make BattOr able to return firmware version.

tools/battor_agent/battor_agent.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_BATTOR_AGENT_BATTOR_AGENT_H_
 #define TOOLS_BATTOR_AGENT_BATTOR_AGENT_H_
 
 #include <map>
 
 #include "base/cancelable_callback.h"
@@ skipping 25 matching lines @@
                     public base::SupportsWeakPtr<BattOrAgent> {
  public:
   // The listener interface that must be implemented in order to interact with
   // the BattOrAgent.
   class Listener {
    public:
     virtual void OnStartTracingComplete(BattOrError error) = 0;
     virtual void OnStopTracingComplete(const std::string& trace,
                                        BattOrError error) = 0;
     virtual void OnRecordClockSyncMarkerComplete(BattOrError error) = 0;
+    virtual void OnGetVersionComplete(const char* version,

[charliea (OOO until 10-5), 2016/10/18 23:46:29]

Probably should use a const std::string& here?

[rnephew (Reviews Here), 2016/10/19 18:23:48]

Done.

+                                      BattOrError error) = 0;
   };
 
   BattOrAgent(
       const std::string& path,
       Listener* listener,
       scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> ui_thread_task_runner);
   virtual ~BattOrAgent();
 
   void StartTracing();
   void StopTracing();
   void RecordClockSyncMarker(const std::string& marker);
+  void GetVersion();
 
   // Returns whether the BattOr is able to record clock sync markers in its own
   // trace log.
   static bool SupportsExplicitClockSync() { return true; }
 
   // BattOrConnection::Listener implementation.
   void OnConnectionOpened(bool success) override;
   void OnBytesSent(bool success) override;
   void OnMessageRead(bool success,
                      BattOrMessageType type,
@@ skipping 10 matching lines @@
   // testing task runner that runs delayed tasks immediately deals poorly with
   // timeouts posted as future tasks.
   virtual void OnActionTimeout();
 
  private:
   enum class Command {
     INVALID,
     START_TRACING,
     STOP_TRACING,
     RECORD_CLOCK_SYNC_MARKER,
+    GET_VERSION,
   };
 
   enum class Action {
     INVALID,
 
     // Actions required to connect to a BattOr.
     REQUEST_CONNECTION,
 
     // Actions required for starting tracing.
     SEND_INIT,
     READ_INIT_ACK,
     SEND_SET_GAIN,
     READ_SET_GAIN_ACK,
     SEND_START_TRACING,
     READ_START_TRACING_ACK,
 
     // Actions required for stopping tracing.
     SEND_EEPROM_REQUEST,
     READ_EEPROM,
     SEND_SAMPLES_REQUEST,
     READ_CALIBRATION_FRAME,
     READ_DATA_FRAME,
 
     // Actions required for recording a clock sync marker.
     SEND_CURRENT_SAMPLE_REQUEST,
     READ_CURRENT_SAMPLE,
+
+    // Actions required for checking firmware version.

[charliea (OOO until 10-5), 2016/10/18 23:46:29]

Maybe "returning the firmware version" instead of "checking firmware version"?

"checking" might indicate that this command compares it against some known good
version or something, whereas this command explicitly just returns what's
already on there.

[rnephew (Reviews Here), 2016/10/19 18:23:47]

Done.

+    SEND_GIT_HASH_REQUEST,
+    READ_GIT_HASH,
   };
 
   // Performs an action.
   void PerformAction(Action action);
   // Performs an action after a delay.
   void PerformDelayedAction(Action action, base::TimeDelta delay);
 
 
 
   // Requests a connection to the BattOr.
@@ skipping 50 matching lines @@
 
   // The number of times we've attempted to init the BattOr.
   uint8_t num_init_attempts_;
 
   // The number of times that we've attempted to read the last message.
   uint8_t num_read_attempts_;
 
   // The timeout that's run when an action times out.
   base::CancelableClosure timeout_callback_;
 
+  // The git hash of the BattOr firmware.
+  char* git_hash_;
+
   DISALLOW_COPY_AND_ASSIGN(BattOrAgent);
 };
 
 }  // namespace battor
 
 #endif  // TOOLS_BATTOR_AGENT_BATTOR_AGENT_H_