Fix crash in Android DevTools port forwarding handler.

Fix crash in Android DevTools port forwarding handler.

This CL fixes a use-after-free in SocketPump::Init() in
content/browser/devtools/protocol/tethering_handler.cc

BUG=652522
Committed: https://crrev.com/e37ae427632f919cceb4f25dfe4669c4d22b313c
Cr-Commit-Position: refs/heads/master@{#422696}

[pwnall, 2016-10-04 01:12:04]

Patchset #1 (id:1) has been deleted

[pwnall, 2016-10-04 01:12:18]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-10-04 01:13:52]

pwnall@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pwnall, 2016-10-04 01:13:53]

PTAL?

This is very similar to a CL that you reviewed a while ago:
http://crrev.com/491533002

[pfeldman, 2016-10-04 01:23:43]

lgtm w/ nit.

https://codereview.chromium.org/2390883003/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/tethering_handler.cc (right):

https://codereview.chromium.org/2390883003/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tethering_handler.cc:46: return channel_name;
nit: return std::string();

[pwnall, 2016-10-04 01:29:52]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:30:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-10-04 01:30:50]

Thank you very much for the feedback and for the quick turnaround!

https://codereview.chromium.org/2390883003/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/tethering_handler.cc (right):

https://codereview.chromium.org/2390883003/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tethering_handler.cc:46: return channel_name;
On 2016/10/04 01:23:42, pfeldman wrote:
> nit: return std::string();

Done.
FWIW, I was (over-)thinking about RVO.

[commit-bot: I haz the power, 2016-10-04 03:43:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:43:24]

Dry run: This issue passed the CQ dry run.

[pwnall, 2016-10-04 03:46:14]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2016-10-04 03:46:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2390883003/#ps40001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2016-10-04 03:46:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 03:51:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-04 03:52:49]

Description was changed from

==========
Fix crash in Android DevTools port forwarding handler.

This CL fixes a use-after-free in SocketPump::Init() in
content/browser/devtools/protocol/tethering_handler.cc

BUG=652522
==========

to

==========
Fix crash in Android DevTools port forwarding handler.

This CL fixes a use-after-free in SocketPump::Init() in
content/browser/devtools/protocol/tethering_handler.cc

BUG=652522

Committed: https://crrev.com/e37ae427632f919cceb4f25dfe4669c4d22b313c
Cr-Commit-Position: refs/heads/master@{#422696}
==========

[commit-bot: I haz the power, 2016-10-04 03:52:50]

Patchset 2 (id:??) landed as
https://crrev.com/e37ae427632f919cceb4f25dfe4669c4d22b313c
Cr-Commit-Position: refs/heads/master@{#422696}