Fix crash in Android DevTools port forwarding handler.

content/browser/devtools/protocol/tethering_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/tethering_handler.h"
 
 #include "base/stl_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/base/io_buffer.h"
 #include "net/base/ip_address.h"
@@ skipping 22 matching lines @@
  public:
   SocketPump(net::StreamSocket* client_socket)
       : client_socket_(client_socket),
         pending_writes_(0),
         pending_destruction_(false) {
   }
 
   std::string Init(const CreateServerSocketCallback& socket_callback) {
     std::string channel_name;
     server_socket_ = socket_callback.Run(&channel_name);
-    if (!server_socket_.get() || channel_name.empty())
+    if (!server_socket_.get() || channel_name.empty()) {
       SelfDestruct();
+      channel_name.clear();
+      return channel_name;

[pfeldman, 2016/10/04 01:23:42]

nit: return std::string();

[pwnall, 2016/10/04 01:30:50]

Done.
FWIW, I was (over-)thinking about RVO.

+    }
 
     int result = server_socket_->Accept(
         &accepted_socket_,
         base::Bind(&SocketPump::OnAccepted, base::Unretained(this)));
     if (result != net::ERR_IO_PENDING)
       OnAccepted(result);
     return channel_name;
   }
 
  private:
@@ skipping 336 matching lines @@
 }
 
 void TetheringHandler::SendInternalError(DevToolsCommandId command_id,
                                          const std::string& message) {
   client_->SendError(command_id, Response::InternalError(message));
 }
 
 }  // namespace tethering
 }  // namespace devtools
 }  // namespace content