Replace InspectedFrames::root with pointer to directly stored LocalFrame

Replace InspectedFrames::root with pointer to directly stored LocalFrame

BUG=635596
Committed: https://crrev.com/d0717890f1c0e5f7311e2284e0381dca050e90c5
Cr-Commit-Position: refs/heads/master@{#422916}

[panicker, 2016-10-03 22:02:52]

panicker@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[panicker, 2016-10-03 22:02:52]

Based on suggestion by Pavel - replacing  reference to InspectedFrames::root

[pfeldman, 2016-10-03 22:06:16]

lgtm

[dgozman, 2016-10-03 22:06:33]

lgtm

https://codereview.chromium.org/2390863002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):

https://codereview.chromium.org/2390863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:53:
Member<LocalFrame> m_localFrame;
We usually call it m_frame, since 95% of blink code only works with local
frames.

[panicker, 2016-10-03 22:10:28]

https://codereview.chromium.org/2390863002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h (right):

https://codereview.chromium.org/2390863002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h:53:
Member<LocalFrame> m_localFrame;
On 2016/10/03 22:06:32, dgozman wrote:
> We usually call it m_frame, since 95% of blink code only works with local
> frames.

localFrame seems more clear to me given that we are on threshold of the OOPIF
world.
Happy to rename if you like though.

[panicker, 2016-10-04 17:30:31]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:31:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:42:52]

Dry run: This issue passed the CQ dry run.

[panicker, 2016-10-04 18:44:02]

The CQ bit was checked by panicker@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:44:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:50:11]

Failed to apply patch for
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp:31
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp' with
conflicts.
  U third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp

Patch:       third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
Index: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
index
2ad9c42c205e34c630e4d334e17b14fefb103cdd..613887a415fb4a741633e8400eedbe9d2b17b119
100644
--- a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
@@ -31,8 +31,8 @@ bool canAccessOrigin(Frame* frame1, Frame* frame2)
 }
 } // namespace
 
-InspectorWebPerfAgent::InspectorWebPerfAgent(InspectedFrames* inspectedFrames)
-    : m_inspectedFrames(inspectedFrames)
+InspectorWebPerfAgent::InspectorWebPerfAgent(LocalFrame* localFrame)
+    : m_localFrame(localFrame)
 {
 }
 
@@ -45,7 +45,7 @@ void InspectorWebPerfAgent::enable()
 {
     Platform::current()->currentThread()->addTaskTimeObserver(this);
     Platform::current()->currentThread()->addTaskObserver(this);
-   
m_inspectedFrames->root()->instrumentingAgents()->addInspectorWebPerfAgent(this);
+    m_localFrame->instrumentingAgents()->addInspectorWebPerfAgent(this);
     m_enabled = true;
 }
 
@@ -53,7 +53,7 @@ void InspectorWebPerfAgent::disable()
 {
     Platform::current()->currentThread()->removeTaskTimeObserver(this);
     Platform::current()->currentThread()->removeTaskObserver(this);
-   
m_inspectedFrames->root()->instrumentingAgents()->removeInspectorWebPerfAgent(this);
+    m_localFrame->instrumentingAgents()->removeInspectorWebPerfAgent(this);
     m_enabled = false;
 }
 
@@ -92,13 +92,13 @@ void InspectorWebPerfAgent::ReportTaskTime(
 {
     if (((endTime - startTime) * 1000) <= kLongTaskThresholdMillis)
         return;
-    DOMWindow* domWindow = m_inspectedFrames->root()->domWindow();
+    DOMWindow* domWindow = m_localFrame->domWindow();
     if (!domWindow)
         return;
     Performance* performance = DOMWindowPerformance::performance(*domWindow);
     DCHECK(performance);
     performance->addLongTaskTiming(startTime, endTime, sanitizedLongTaskName(
-        m_frameContextLocations, m_inspectedFrames->root()));
+        m_frameContextLocations, m_localFrame));
 }
 
 String InspectorWebPerfAgent::sanitizedLongTaskName(
@@ -124,7 +124,7 @@ String InspectorWebPerfAgent::sanitizedLongTaskName(
 
 DEFINE_TRACE(InspectorWebPerfAgent)
 {
-    visitor->trace(m_inspectedFrames);
+    visitor->trace(m_localFrame);
     visitor->trace(m_frameContextLocations);
 }

[panicker, 2016-10-04 18:53:20]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-10-04 18:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2390863002/#ps20001
(title: "sync to head")

[commit-bot: I haz the power, 2016-10-04 18:53:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:39:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 20:41:36]

Description was changed from

==========
Replace InspectedFrames::root with pointer to directly stored LocalFrame

BUG=635596
==========

to

==========
Replace InspectedFrames::root with pointer to directly stored LocalFrame

BUG=635596

Committed: https://crrev.com/d0717890f1c0e5f7311e2284e0381dca050e90c5
Cr-Commit-Position: refs/heads/master@{#422916}
==========

[commit-bot: I haz the power, 2016-10-04 20:41:38]

Patchset 2 (id:??) landed as
https://crrev.com/d0717890f1c0e5f7311e2284e0381dca050e90c5
Cr-Commit-Position: refs/heads/master@{#422916}