Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp

Issue 2390863002: Replace InspectedFrames::root with pointer to directly stored LocalFrame (Closed)
Patch Set: sync to head Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
index 6fd1f79e11d6e923fdbe4e5a5d817f00004a9f25..7fe01378dd6d20bde651ab601ab0b81c26ac056c 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
@@ -32,8 +32,8 @@ bool canAccessOrigin(Frame* frame1, Frame* frame2) {
}
} // namespace
-InspectorWebPerfAgent::InspectorWebPerfAgent(InspectedFrames* inspectedFrames)
- : m_inspectedFrames(inspectedFrames) {}
+InspectorWebPerfAgent::InspectorWebPerfAgent(LocalFrame* localFrame)
+ : m_localFrame(localFrame) {}
InspectorWebPerfAgent::~InspectorWebPerfAgent() {
DCHECK(!m_enabled);
@@ -42,16 +42,14 @@ InspectorWebPerfAgent::~InspectorWebPerfAgent() {
void InspectorWebPerfAgent::enable() {
Platform::current()->currentThread()->addTaskTimeObserver(this);
Platform::current()->currentThread()->addTaskObserver(this);
- m_inspectedFrames->root()->instrumentingAgents()->addInspectorWebPerfAgent(
- this);
+ m_localFrame->instrumentingAgents()->addInspectorWebPerfAgent(this);
m_enabled = true;
}
void InspectorWebPerfAgent::disable() {
Platform::current()->currentThread()->removeTaskTimeObserver(this);
Platform::current()->currentThread()->removeTaskObserver(this);
- m_inspectedFrames->root()->instrumentingAgents()->removeInspectorWebPerfAgent(
- this);
+ m_localFrame->instrumentingAgents()->removeInspectorWebPerfAgent(this);
m_enabled = false;
}
@@ -82,14 +80,14 @@ void InspectorWebPerfAgent::ReportTaskTime(scheduler::TaskQueue*,
double endTime) {
if (((endTime - startTime) * 1000) <= kLongTaskThresholdMillis)
return;
- DOMWindow* domWindow = m_inspectedFrames->root()->domWindow();
+ DOMWindow* domWindow = m_localFrame->domWindow();
if (!domWindow)
return;
Performance* performance = DOMWindowPerformance::performance(*domWindow);
DCHECK(performance);
performance->addLongTaskTiming(
- startTime, endTime, sanitizedLongTaskName(m_frameContextLocations,
- m_inspectedFrames->root()));
+ startTime, endTime,
+ sanitizedLongTaskName(m_frameContextLocations, m_localFrame));
}
String InspectorWebPerfAgent::sanitizedLongTaskName(
@@ -114,7 +112,7 @@ String InspectorWebPerfAgent::sanitizedLongTaskName(
}
DEFINE_TRACE(InspectorWebPerfAgent) {
- visitor->trace(m_inspectedFrames);
+ visitor->trace(m_localFrame);
visitor->trace(m_frameContextLocations);
}

Powered by Google App Engine
This is Rietveld 408576698