Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: chrome/browser/extensions/requirements_checker.cc

Issue 239083006: Change ACCELERATED_COMPOSITING blacklist to GPU_COMPOSITING. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blacklistaccel: tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/requirements_checker.cc
diff --git a/chrome/browser/extensions/requirements_checker.cc b/chrome/browser/extensions/requirements_checker.cc
index c1bbadde40a32aae66df28c941f31c2ab50648c8..71eb8f1c9e59f58ee5c5675655304c8f02c1c219 100644
--- a/chrome/browser/extensions/requirements_checker.cc
+++ b/chrome/browser/extensions/requirements_checker.cc
@@ -64,14 +64,6 @@ void RequirementsChecker::Check(scoped_refptr<const Extension> extension,
AsWeakPtr()));
}
- if (requirements.css3d) {
- ++pending_requirement_checks_;
- css3d_checker_ = new GPUFeatureChecker(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING,
- base::Bind(&RequirementsChecker::SetCSS3DAvailability,
- AsWeakPtr()));
- }
-
if (pending_requirement_checks_ == 0) {
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
base::Bind(callback_, errors_));
@@ -83,8 +75,6 @@ void RequirementsChecker::Check(scoped_refptr<const Extension> extension,
// from the use of pending_requirement_checks_.
if (webgl_checker_.get())
webgl_checker_->CheckGPUFeatureAvailability();
- if (css3d_checker_.get())
- css3d_checker_->CheckGPUFeatureAvailability();
}
void RequirementsChecker::SetWebGLAvailability(bool available) {
@@ -95,14 +85,6 @@ void RequirementsChecker::SetWebGLAvailability(bool available) {
MaybeRunCallback();
}
-void RequirementsChecker::SetCSS3DAvailability(bool available) {
- if (!available) {
- errors_.push_back(
- l10n_util::GetStringUTF8(IDS_EXTENSION_CSS3D_NOT_SUPPORTED));
- }
- MaybeRunCallback();
-}
-
void RequirementsChecker::MaybeRunCallback() {
if (--pending_requirement_checks_ == 0) {
content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
« no previous file with comments | « chrome/browser/extensions/requirements_checker.h ('k') | chrome/browser/extensions/requirements_checker_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698