Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: chrome/browser/extensions/requirements_checker_browsertest.cc

Issue 239083006: Change ACCELERATED_COMPOSITING blacklist to GPU_COMPOSITING. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blacklistaccel: tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/requirements_checker_browsertest.cc
diff --git a/chrome/browser/extensions/requirements_checker_browsertest.cc b/chrome/browser/extensions/requirements_checker_browsertest.cc
index 9115aec3ad7e04d4258ca9f9afa1bb12ef7812a9..590498fd5bae4707c7ae5ae2f60e00a934b016ce 100644
--- a/chrome/browser/extensions/requirements_checker_browsertest.cc
+++ b/chrome/browser/extensions/requirements_checker_browsertest.cc
@@ -118,27 +118,6 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest,
content::BrowserThread::GetBlockingPool()->FlushForTesting();
}
-IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowCSS3D) {
- scoped_refptr<const Extension> extension(
- LoadExtensionFromDirName("require_3d"));
- ASSERT_TRUE(extension.get());
-
- // Blacklist css3d
- std::vector<std::string> blacklisted_features;
- blacklisted_features.push_back("accelerated_compositing");
- BlackListGPUFeatures(blacklisted_features);
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
-
- std::vector<std::string> expected_errors;
- expected_errors.push_back(l10n_util::GetStringUTF8(
- IDS_EXTENSION_CSS3D_NOT_SUPPORTED));
-
- checker_.Check(extension, base::Bind(
- &RequirementsCheckerBrowserTest::ValidateRequirementErrors,
- base::Unretained(this), expected_errors));
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
-}
-
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowWebGL) {
scoped_refptr<const Extension> extension(
LoadExtensionFromDirName("require_3d"));
@@ -160,30 +139,6 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowWebGL) {
content::BrowserThread::GetBlockingPool()->FlushForTesting();
}
-IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowGPUFeatures) {
- scoped_refptr<const Extension> extension(
- LoadExtensionFromDirName("require_3d"));
- ASSERT_TRUE(extension.get());
-
- // Backlist both webgl and css3d
- std::vector<std::string> blacklisted_features;
- blacklisted_features.push_back("webgl");
- blacklisted_features.push_back("accelerated_compositing");
- BlackListGPUFeatures(blacklisted_features);
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
-
- std::vector<std::string> expected_errors;
- expected_errors.push_back(l10n_util::GetStringUTF8(
- IDS_EXTENSION_WEBGL_NOT_SUPPORTED));
- expected_errors.push_back(l10n_util::GetStringUTF8(
- IDS_EXTENSION_CSS3D_NOT_SUPPORTED));
-
- checker_.Check(extension, base::Bind(
- &RequirementsCheckerBrowserTest::ValidateRequirementErrors,
- base::Unretained(this), expected_errors));
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
-}
-
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, Check3DExtension) {
scoped_refptr<const Extension> extension(
LoadExtensionFromDirName("require_3d"));
@@ -194,8 +149,6 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, Check3DExtension) {
if (!content::GpuDataManager::GetInstance()->GpuAccessAllowed(NULL)) {
expected_errors.push_back(l10n_util::GetStringUTF8(
IDS_EXTENSION_WEBGL_NOT_SUPPORTED));
- expected_errors.push_back(l10n_util::GetStringUTF8(
- IDS_EXTENSION_CSS3D_NOT_SUPPORTED));
}
checker_.Check(extension, base::Bind(

Powered by Google App Engine
This is Rietveld 408576698