Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2390793002: Removed Ash.AppList.TimeBetweenTaskSwitches and Ash.Tab.TimeBetweenSwitchToExistingTabUserActions h… (Closed)

Created:
4 years, 2 months ago by bruthig
Modified:
4 years, 2 months ago
Reviewers:
rkaplow, sky
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, asvitkine+watch_chromium.org, tfarina, tdanderson, riajiang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed Ash.AppList.TimeBetweenTaskSwitches and Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histograms. These histograms are triggered in the chrome process but are actually recorded in ash (which is in a different process). This is problematic for the mus+ash refactoring and since there are no clear decisions being made from these metrics they are being removed. BUG=616581 TEST=ash_unittests Committed: https://crrev.com/9a7916b557200bb2ea8291732158e200f434078b Cr-Commit-Position: refs/heads/master@{#422885}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed up ash_unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -137 lines) Patch
M ash/common/metrics/task_switch_source.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder_unittest.cc View 1 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/ash/metrics/chrome_user_metrics_recorder.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 24 (14 generated)
bruthig
sky@, can you PTAL?
4 years, 2 months ago (2016-10-03 18:11:23 UTC) #4
bruthig
4 years, 2 months ago (2016-10-03 18:11:56 UTC) #5
sky
https://codereview.chromium.org/2390793002/diff/1/ash/common/metrics/task_switch_source.h File ash/common/metrics/task_switch_source.h (left): https://codereview.chromium.org/2390793002/diff/1/ash/common/metrics/task_switch_source.h#oldcode17 ash/common/metrics/task_switch_source.h:17: APP_LIST, Are these values written to a histogram?
4 years, 2 months ago (2016-10-03 19:11:51 UTC) #8
bruthig
https://codereview.chromium.org/2390793002/diff/1/ash/common/metrics/task_switch_source.h File ash/common/metrics/task_switch_source.h (left): https://codereview.chromium.org/2390793002/diff/1/ash/common/metrics/task_switch_source.h#oldcode17 ash/common/metrics/task_switch_source.h:17: APP_LIST, On 2016/10/03 19:11:51, sky wrote: > Are these ...
4 years, 2 months ago (2016-10-04 14:17:09 UTC) #11
sky
Ok, LGTM. And thanks for the cleanup!
4 years, 2 months ago (2016-10-04 18:20:17 UTC) #15
bruthig
rkaplow@, can you take a quick look at histograms.xml?
4 years, 2 months ago (2016-10-04 18:49:25 UTC) #17
rkaplow
lgtm
4 years, 2 months ago (2016-10-04 19:24:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390793002/20001
4 years, 2 months ago (2016-10-04 19:27:14 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 19:34:52 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:37:53 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a7916b557200bb2ea8291732158e200f434078b
Cr-Commit-Position: refs/heads/master@{#422885}

Powered by Google App Engine
This is Rietveld 408576698