Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: ash/metrics/task_switch_metrics_recorder_unittest.cc

Issue 2390793002: Removed Ash.AppList.TimeBetweenTaskSwitches and Ash.Tab.TimeBetweenSwitchToExistingTabUserActions h… (Closed)
Patch Set: Fixed up ash_unittests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/metrics/task_switch_metrics_recorder.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/metrics/task_switch_metrics_recorder.h" 5 #include "ash/metrics/task_switch_metrics_recorder.h"
6 6
7 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace ash { 10 namespace ash {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 "Ash.Shelf.TimeBetweenNavigateToTaskSwitches"; 107 "Ash.Shelf.TimeBetweenNavigateToTaskSwitches";
108 108
109 OnTaskSwitch(TaskSwitchSource::SHELF); 109 OnTaskSwitch(TaskSwitchSource::SHELF);
110 OnTaskSwitch(TaskSwitchSource::SHELF); 110 OnTaskSwitch(TaskSwitchSource::SHELF);
111 histogram_tester_->ExpectTotalCount(kHistogramName, 1); 111 histogram_tester_->ExpectTotalCount(kHistogramName, 1);
112 112
113 OnTaskSwitch(TaskSwitchSource::SHELF); 113 OnTaskSwitch(TaskSwitchSource::SHELF);
114 histogram_tester_->ExpectTotalCount(kHistogramName, 2); 114 histogram_tester_->ExpectTotalCount(kHistogramName, 2);
115 } 115 }
116 116
117 // Verifies that the TaskSwitchSource::TAB_STRIP source adds data to
118 // the Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histogram.
119 TEST_F(TaskSwitchMetricsRecorderTest,
120 VerifyTaskSwitchesFromTheTabStripAreRecorded) {
121 const std::string kHistogramName =
122 "Ash.Tab.TimeBetweenSwitchToExistingTabUserActions";
123
124 OnTaskSwitch(TaskSwitchSource::TAB_STRIP);
125 OnTaskSwitch(TaskSwitchSource::TAB_STRIP);
126 histogram_tester_->ExpectTotalCount(kHistogramName, 1);
127
128 OnTaskSwitch(TaskSwitchSource::TAB_STRIP);
129 histogram_tester_->ExpectTotalCount(kHistogramName, 2);
130 }
131
132 // Verifies that the TaskSwitchSource::OVERVIEW_MODE source adds data 117 // Verifies that the TaskSwitchSource::OVERVIEW_MODE source adds data
133 // to the Ash.WindowSelector.TimeBetweenActiveWindowChanges histogram. 118 // to the Ash.WindowSelector.TimeBetweenActiveWindowChanges histogram.
134 TEST_F(TaskSwitchMetricsRecorderTest, 119 TEST_F(TaskSwitchMetricsRecorderTest,
135 VerifyTaskSwitchesFromOverviewModeAreRecorded) { 120 VerifyTaskSwitchesFromOverviewModeAreRecorded) {
136 const std::string kHistogramName = 121 const std::string kHistogramName =
137 "Ash.WindowSelector.TimeBetweenActiveWindowChanges"; 122 "Ash.WindowSelector.TimeBetweenActiveWindowChanges";
138 123
139 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE); 124 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE);
140 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE); 125 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE);
141 histogram_tester_->ExpectTotalCount(kHistogramName, 1); 126 histogram_tester_->ExpectTotalCount(kHistogramName, 1);
142 127
143 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE); 128 OnTaskSwitch(TaskSwitchSource::OVERVIEW_MODE);
144 histogram_tester_->ExpectTotalCount(kHistogramName, 2); 129 histogram_tester_->ExpectTotalCount(kHistogramName, 2);
145 } 130 }
146 131
147 // Verifies that the TaskSwitchSource::APP_LIST source adds data to the
148 // Ash.AppList.TimeBetweenTaskSwitches histogram.
149 TEST_F(TaskSwitchMetricsRecorderTest,
150 VerifyTaskSwitchesFromApplistAreRecorded) {
151 const std::string kHistogramName = "Ash.AppList.TimeBetweenTaskSwitches";
152
153 OnTaskSwitch(TaskSwitchSource::APP_LIST);
154 OnTaskSwitch(TaskSwitchSource::APP_LIST);
155 histogram_tester_->ExpectTotalCount(kHistogramName, 1);
156
157 OnTaskSwitch(TaskSwitchSource::APP_LIST);
158 histogram_tester_->ExpectTotalCount(kHistogramName, 2);
159 }
160
161 } // namespace ash 132 } // namespace ash
OLDNEW
« no previous file with comments | « ash/metrics/task_switch_metrics_recorder.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698