Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2390783007: GN: Use gcc for ia32 Linux (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Use gcc for ia32 Linux Clang doesn't compile tcmalloc's ia32 inline assembly correctly. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f688cef70d8f27f6074714f9c154ba263bb1ead8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-10-06 18:24:54 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-10-06 18:25:38 UTC) #3
zra
4 years, 2 months ago (2016-10-06 18:28:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f688cef70d8f27f6074714f9c154ba263bb1ead8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698