tools/gn.py - Issue 2390783007: GN: Use gcc for ia32 Linux - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(3)

My Issues | Starred Open | Closed | All

Unified Diff: tools/gn.py

Issue 2390783007: GN: Use gcc for ia32 Linux (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py

index 7598b5f862958773934b7e727accdc58350da771..814441d382c331436b383f32d32196af1c8dd8b2 100755

--- a/tools/gn.py

+++ b/tools/gn.py

@@ -102,8 +102,11 @@ def to_gn_args(args, mode, arch, target_os):

gn_args['dart_runtime_mode'] = 'develop'

# TODO(zra): Investigate using clang with these configurations.

+ # Clang compiles tcmalloc's inline assembly for ia32 on Linux wrong, so we

+ # don't use clang in that configuration.

has_clang = (host_os != 'win'

and args.os not in ['android']

+ and not (gn_args['target_os'] == 'linux' and arch == 'ia32')

and not gn_args['target_cpu'].startswith('arm')

and not gn_args['target_cpu'].startswith('mips'))

gn_args['is_clang'] = args.clang and has_clang

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698