Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)
Patch Set: Rebase, address comments, revert images Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
index b0eb77ce18e23eae8914db0c6aaf3e34fb0ae9cd..d3aa5a1f1b2709dce9440ffafdc3ecb26245db0f 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
@@ -12,6 +12,7 @@
namespace blink {
class AXObject;
+class AXObjectCacheImpl;
class InspectorDOMAgent;
class Page;
@@ -26,9 +27,9 @@ class MODULES_EXPORT InspectorAccessibilityAgent
DECLARE_VIRTUAL_TRACE();
// Protocol methods.
- Response getAXNodeChain(
+ Response getPartialAXTree(
int domNodeId,
- bool fetchAncestors,
+ Maybe<bool> fetchRelatives,
std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>*)
override;
@@ -38,10 +39,67 @@ class MODULES_EXPORT InspectorAccessibilityAgent
std::unique_ptr<protocol::Accessibility::AXNode> buildObjectForIgnoredNode(
Node* domNode,
- AXObject*) const;
+ AXObject*,
+ bool fetchRelatives,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void populateDOMNodeRelatives(
+ Node& inspectedDOMNode,
+ protocol::Accessibility::AXNode&,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void findDOMNodeChildren(
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+ childIds,
+ Node& parentNode,
+ Node& inspectedDOMNode,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
std::unique_ptr<protocol::Accessibility::AXNode> buildProtocolAXObject(
- AXObject&) const;
- void fillCoreProperties(AXObject&, protocol::Accessibility::AXNode&) const;
+ AXObject&,
+ AXObject* inspectedAXObject,
+ bool fetchRelatives,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void fillCoreProperties(
+ AXObject&,
+ AXObject* inspectedAXObject,
+ bool fetchRelatives,
+ protocol::Accessibility::AXNode&,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addAncestors(
+ AXObject& firstAncestor,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void populateRelatives(
+ AXObject&,
+ AXObject* inspectedAXObject,
+ protocol::Accessibility::AXNode&,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addSiblingsOfIgnored(
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+ childIds,
+ AXObject& parentAXObject,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addChild(
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+ childIds,
+ AXObject& childAXObject,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
+ void addChildren(
+ AXObject&,
+ AXObject* inspectedAXObject,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNodeId>>&
+ childIds,
+ std::unique_ptr<protocol::Array<protocol::Accessibility::AXNode>>& nodes,
+ AXObjectCacheImpl&) const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698