Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2390783006: [DevTools] Accessibility: Show siblings and children of selected node (Closed)
Patch Set: Rebase, address comments, revert images Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index b76be955dc1b53fb3aca91cd253141c108366648..57ec58fd7edb79cfc72548599b94f7670dcd5d6b 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -29,22 +29,23 @@ WebInspector.AccessibilitySidebarView = class extends WebInspector.ThrottledWidg
}
/**
- * @param {?Array<!WebInspector.AccessibilityNode>} nodes
+ * @param {?WebInspector.AccessibilityNode} axNode
*/
- accessibilityNodeCallback(nodes) {
- if (!nodes)
+ accessibilityNodeCallback(axNode) {
+ if (!axNode)
return;
- var currentAXNode = nodes[0];
- if (currentAXNode.ignored)
+ this._axNode = axNode;
+
+ if (axNode.ignored())
this._sidebarPaneStack.removeView(this._ariaSubPane);
else
this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
if (this._axNodeSubPane)
- this._axNodeSubPane.setAXNode(currentAXNode);
+ this._axNodeSubPane.setAXNode(axNode);
if (this._treeSubPane)
- this._treeSubPane.setAXNodeAndAncestors(nodes);
+ this._treeSubPane.setAXNode(axNode);
}
/**
@@ -57,9 +58,13 @@ WebInspector.AccessibilitySidebarView = class extends WebInspector.ThrottledWidg
this._treeSubPane.setNode(node);
this._axNodeSubPane.setNode(node);
this._ariaSubPane.setNode(node);
- return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNodeChain(node).then((nodes) => {
- this.accessibilityNodeCallback(nodes);
- });
+ if (!node)
+ return Promise.resolve();
+ var accessibilityModel = WebInspector.AccessibilityModel.fromTarget(node.target());
+ return accessibilityModel.requestPartialAXTree(node)
dgozman 2016/11/04 23:22:45 accessibilityModel.clear()
aboxhall 2016/11/07 19:54:43 Done.
dgozman 2016/11/08 16:38:41 Missed?
aboxhall 2016/11/08 18:02:18 Oops, forgot to save!
+ .then(() => {
+ this.accessibilityNodeCallback(accessibilityModel.axNodeForDOMNode(node));
+ });
}
/**

Powered by Google App Engine
This is Rietveld 408576698