Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2390743003: Prep-CL for adding new RTCStatsMeember types in WebRTC repo. (Closed)

Created:
4 years, 2 months ago by hbos_chromium
Modified:
4 years, 2 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prep-CL for adding new RTCStatsMeember types in WebRTC repo. If-statement prevents a crash in a unittest that would occur if rolling after the WebRTC change. The WebRTC change: https://codereview.webrtc.org/2387343002/ BUG=chromium:627816 Committed: https://crrev.com/432e9601d9104b5fa560a96eb598e7415a87e7c0 Cr-Commit-Position: refs/heads/master@{#422758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Guido Urdaneta
lgtm
4 years, 2 months ago (2016-10-04 11:16:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390743003/1
4 years, 2 months ago (2016-10-04 11:17:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 11:47:54 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 11:51:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/432e9601d9104b5fa560a96eb598e7415a87e7c0
Cr-Commit-Position: refs/heads/master@{#422758}

Powered by Google App Engine
This is Rietveld 408576698