Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 2390743003: Prep-CL for adding new RTCStatsMeember types in WebRTC repo. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index 3e0ecf8e86e397284f9efd2e13ff226564d81ad6..c9d99a01b906141671adafdb0ef48b69d8dfed2d 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -720,6 +720,12 @@ TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
for (size_t i = 0; i < stats->membersCount(); ++i) {
std::unique_ptr<blink::WebRTCStatsMember> member =
stats->getMember(i);
+ // TODO(hbos): A WebRTC-change is adding new members, this would cause
+ // not all members to be defined. This if-statement saves Chromium from
+ // crashing. As soon as the change has been rolled in, I will update
+ // this test. crbug.com/627816
+ if (!member->isDefined())
+ continue;
EXPECT_TRUE(member->isDefined());
members.insert(member->type());
switch (member->type()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698