Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2390683003: In Port.setup_environ_for_server, don't copy apparently unused env vars. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In Port.setup_environ_for_server, don't copy apparently unused env vars. Committed: https://crrev.com/42596be2957d3f08102ffe9dc70b317cc146c047 Cr-Commit-Position: refs/heads/master@{#422967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
This is a low-priority clean-up CL. Dirk, in 2013 you added comments here asking if ...
4 years, 2 months ago (2016-10-03 23:28:41 UTC) #2
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-04 20:12:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390683003/1
4 years, 2 months ago (2016-10-04 21:09:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 22:24:31 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:27:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42596be2957d3f08102ffe9dc70b317cc146c047
Cr-Commit-Position: refs/heads/master@{#422967}

Powered by Google App Engine
This is Rietveld 408576698