Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2390683003: In Port.setup_environ_for_server, don't copy apparently unused env vars. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 1062
1063 def clean_up_test_run(self): 1063 def clean_up_test_run(self):
1064 """Perform port-specific work at the end of a test run.""" 1064 """Perform port-specific work at the end of a test run."""
1065 if self._image_differ: 1065 if self._image_differ:
1066 self._image_differ.stop() 1066 self._image_differ.stop()
1067 self._image_differ = None 1067 self._image_differ = None
1068 1068
1069 def setup_environ_for_server(self): 1069 def setup_environ_for_server(self):
1070 # We intentionally copy only a subset of the environment when 1070 # We intentionally copy only a subset of the environment when
1071 # launching subprocesses to ensure consistent test results. 1071 # launching subprocesses to ensure consistent test results.
1072 clean_env = { 1072 clean_env = {}
1073 'LOCAL_RESOURCE_ROOT': self.layout_tests_dir(), # FIXME: Is this us ed?
1074 }
1075 variables_to_copy = [ 1073 variables_to_copy = [
1076 'WEBKIT_TESTFONTS', # FIXME: Is this still used?
1077 'WEBKITOUTPUTDIR', # FIXME: Is this still used?
1078 'CHROME_DEVEL_SANDBOX', 1074 'CHROME_DEVEL_SANDBOX',
1079 'CHROME_IPC_LOGGING', 1075 'CHROME_IPC_LOGGING',
1080 'ASAN_OPTIONS', 1076 'ASAN_OPTIONS',
1081 'TSAN_OPTIONS', 1077 'TSAN_OPTIONS',
1082 'MSAN_OPTIONS', 1078 'MSAN_OPTIONS',
1083 'LSAN_OPTIONS', 1079 'LSAN_OPTIONS',
1084 'UBSAN_OPTIONS', 1080 'UBSAN_OPTIONS',
1085 'VALGRIND_LIB', 1081 'VALGRIND_LIB',
1086 'VALGRIND_LIB_INNER', 1082 'VALGRIND_LIB_INNER',
1087 ] 1083 ]
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
1818 1814
1819 def __init__(self, base, args, reference_args=None): 1815 def __init__(self, base, args, reference_args=None):
1820 self.name = base 1816 self.name = base
1821 self.base = base 1817 self.base = base
1822 self.args = args 1818 self.args = args
1823 self.reference_args = args if reference_args is None else reference_args 1819 self.reference_args = args if reference_args is None else reference_args
1824 self.tests = set() 1820 self.tests = set()
1825 1821
1826 def __repr__(self): 1822 def __repr__(self):
1827 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1823 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698